Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dra publish step #226

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix dra publish step #226

merged 1 commit into from
Jan 30, 2024

Conversation

dliappis
Copy link
Contributor

This commit fixes a bug introduced in PR #212 which missed the switch from WORKFLOW -> DRA_WORKFLOW from the publish step, resulting in failures1.

Footnotes

  1. https://buildkite.com/elastic/elastic-stack-installers/builds/3641#018d5b0b-5ae5-404c-b79f-211468f45413/51-52

This commit fixes a bug introduced in PR elastic#212 which missed the switch
from WORKFLOW -> DRA_WORKFLOW from the publish step, resulting
in failures[^1].

[^1]: https://buildkite.com/elastic/elastic-stack-installers/builds/3641#018d5b0b-5ae5-404c-b79f-211468f45413/51-52
@dliappis dliappis added the bug Something isn't working label Jan 30, 2024
@dliappis dliappis requested a review from DaveSys911 January 30, 2024 16:28
@dliappis dliappis self-assigned this Jan 30, 2024
@dliappis dliappis requested a review from a team as a code owner January 30, 2024 16:28
Copy link
Contributor

@DaveSys911 DaveSys911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dliappis dliappis merged commit 18f56e0 into elastic:main Jan 30, 2024
2 checks passed
dliappis added a commit that referenced this pull request Jan 30, 2024
This commit fixes a bug introduced in PR #212 which missed the switch
from WORKFLOW -> DRA_WORKFLOW from the publish step, resulting
in failures[^1].

[^1]: https://buildkite.com/elastic/elastic-stack-installers/builds/3641#018d5b0b-5ae5-404c-b79f-211468f45413/51-52
@dliappis
Copy link
Contributor Author

Backported to 8.12 in 98f830a

dliappis added a commit to dliappis/elastic-stack-installers that referenced this pull request Jan 31, 2024
DaveSys911 pushed a commit that referenced this pull request Jan 31, 2024
* Revert "Fix artifacts path for dra publish (#227)"

This reverts commit 2739036.

* Revert "Fix dra publish step (#226)"

This reverts commit 98f830a.

* Revert "Agent MSI support (#212)"

This reverts commit ffffea6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants