Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix artifacts path for dra publish #227

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Fix artifacts path for dra publish #227

merged 1 commit into from
Jan 31, 2024

Conversation

dliappis
Copy link
Contributor

This commit fixes the downloaded artifacts path to the expected path by the release manager image (bin/out).

The original path was changed in #212 and the previous step because path lengths exceeded a limit imposed by the msi builder.

Example failure: https://buildkite.com/elastic/elastic-stack-installers/builds/3653#018d5d99-9403-41b5-9023-613016deb033/51-54

This commit fixes the downloaded artifacts path to the expected path
by the release manager image (`bin/out`).

The original path was changed in #212 and the previous step because path
lengths exceeded a limit imposed by the msi builder.
@dliappis dliappis added the bug Something isn't working label Jan 31, 2024
@dliappis dliappis requested a review from DaveSys911 January 31, 2024 08:13
@dliappis dliappis self-assigned this Jan 31, 2024
@dliappis dliappis requested a review from a team as a code owner January 31, 2024 08:13
Copy link
Contributor

@DaveSys911 DaveSys911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dliappis dliappis merged commit 9c7c0a6 into main Jan 31, 2024
2 of 3 checks passed
@dliappis dliappis deleted the fix-bin-out-paths branch January 31, 2024 10:20
dliappis added a commit that referenced this pull request Jan 31, 2024
This commit fixes the downloaded artifacts path to the expected path by the release manager image (bin/out).

The original path was changed in #212 and the previous step because path lengths exceeded a limit imposed by the msi builder.
dliappis added a commit to dliappis/elastic-stack-installers that referenced this pull request Jan 31, 2024
DaveSys911 pushed a commit that referenced this pull request Jan 31, 2024
* Revert "Fix artifacts path for dra publish (#227)"

This reverts commit 2739036.

* Revert "Fix dra publish step (#226)"

This reverts commit 98f830a.

* Revert "Agent MSI support (#212)"

This reverts commit ffffea6.
dliappis added a commit that referenced this pull request Feb 2, 2024
This commit fixes the downloaded artifacts path to the expected path by the release manager image (bin/out).

The original path was changed in #212 and the previous step because path lengths exceeded a limit imposed by the msi builder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants