Support synthetic_source_keep and mapping.source.mode #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
commented
Jan 24, 2025
| @@ -420,7 +420,8 @@ export class MappingLimitSettings { | |||
| nested_objects?: MappingLimitSettingsNestedObjects | |||
| field_name_length?: MappingLimitSettingsFieldNameLength | |||
| dimension_fields?: MappingLimitSettingsDimensionFields | |||
| ignore_malformed?: boolean | |||
| source?: MappingLimitSettingsSourceFields | |||
| ignore_malformed?: boolean | string | |||
There was a problem hiding this comment.
I accidentally added this other change. Like all settings, it can be a string, which happens in the cluster.get_component_templates response recordings we have.
This comment was marked as outdated.
This comment was marked as outdated.
l-trotta
reviewed
Jan 24, 2025
| @@ -420,7 +420,8 @@ export class MappingLimitSettings { | |||
| nested_objects?: MappingLimitSettingsNestedObjects | |||
| field_name_length?: MappingLimitSettingsFieldNameLength | |||
| dimension_fields?: MappingLimitSettingsDimensionFields | |||
| ignore_malformed?: boolean | |||
| source?: MappingLimitSettingsSourceFields | |||
There was a problem hiding this comment.
took me a while to find the matching names in the server code, so I have a suggestion: what about calling this 'source.mode', skipping the intermediate class?
There was a problem hiding this comment.
I've done this in 3b71a0d (#3596) but that breaks validation, maybe because validation is not smart enough? Ah, the joy of index settings.
This comment was marked as outdated.
This comment was marked as outdated.
This reverts commit 3b71a0d.
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
l-trotta
approved these changes
Jan 24, 2025
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3596-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 aecc157b6c01a4b766728dff030232a53b23f00d
# Push it to GitHub
git push --set-upstream origin backport-3596-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17Then, create a pull request where the |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
pquentin
added a commit
that referenced
this pull request
Jan 28, 2025
* Support synthetic_source_keep and mapping.source.mode * Skip intermediate class * Revert "Skip intermediate class" This reverts commit 3b71a0d. (cherry picked from commit aecc157) Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a few errors from
make validate api=cluster.get_component_template branch=main.