Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uppercase enum source mode #3676

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Uppercase enum source mode #3676

merged 2 commits into from
Jan 31, 2025
+16 −16

Conversation

l-trotta
Copy link
Contributor

@l-trotta l-trotta commented Jan 31, 2025 •
edited
Loading

Followup of #3596 - server accepts both lowercase and uppercase strings for this enum, but always returns the uppercase version, breaking the java client because the deserialization of enums is case sensitive.
Tested calling:

PUT /my-index
GET /my-index/_settings?include_defaults=true

returns:

...
  "source": {
      "mode": "STORED"
  },
...

@l-trotta l-trotta requested a review from pquentin January 31, 2025 16:36
@l-trotta l-trotta requested a review from flobernd January 31, 2025 16:36
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.add_block 🟢 2/2 2/2
indices.analyze 🟢 243/243 243/243
indices.cancel_migrate_reindex 🟢 2/2 2/2
indices.clear_cache 🟢 4/4 4/4
indices.clone 🟢 5/5 5/5
indices.close 🟢 49/49 49/49
indices.create_data_stream 🟢 31/31 31/31
indices.create_from 🟢 4/4 4/4
indices.create 🔴 961/1174 1174/1174
indices.data_streams_stats 🟢 4/4 4/4
indices.delete_alias 🔴 12/12 5/12
indices.delete_data_lifecycle ⚪ Missing test Missing test
indices.delete_data_stream 🟢 28/28 28/28
indices.delete_index_template 🟢 1/1 1/1
indices.delete_template 🟢 9/9 9/9
indices.delete 🟢 105/105 105/105
indices.disk_usage 🟢 6/6 6/6
indices.downsample 🟢 2/2 2/2
indices.exists_alias 🟢 37/37 37/37
indices.exists_index_template ⚪ Missing test Missing test
indices.exists_template 🟢 15/15 15/15
indices.exists 🟢 39/39 39/39
indices.explain_data_lifecycle ⚪ Missing test Missing test
indices.field_usage_stats 🟢 5/5 5/5
indices.flush 🟢 41/41 41/41
indices.forcemerge 🟢 12/12 12/12
indices.get_alias 🟢 68/68 68/68
indices.get_data_lifecycle_stats ⚪ Missing test Missing test
indices.get_data_lifecycle ⚪ Missing test Missing test
indices.get_data_stream 🟢 11/11 11/11
indices.get_field_mapping 🟢 15/15 15/15
indices.get_index_template 🔴 21/21 17/21
indices.get_mapping 🔴 135/135 133/135
indices.get_migrate_reindex_status 🟢 1/1 1/1
indices.get_settings 🔴 76/76 69/76
indices.get_template 🟢 32/32 32/32
indices.get 🔴 55/55 53/55
indices.migrate_reindex 🟢 2/2 2/2
indices.migrate_to_data_stream ⚪ Missing test Missing test
indices.modify_data_stream ⚪ Missing test Missing test
indices.open 🟢 20/20 20/20
indices.promote_data_stream ⚪ Missing test Missing test
indices.put_alias 🔴 58/58 20/58
indices.put_data_lifecycle ⚪ Missing test Missing test
indices.put_index_template 🔴 59/68 68/68
indices.put_mapping 🔴 111/117 117/117
indices.put_settings 🔴 55/58 58/58
indices.put_template 🔴 45/46 46/46
indices.recovery 🟢 9/9 9/9
indices.refresh 🟢 275/275 275/275
indices.reload_search_analyzers 🟢 2/2 2/2
indices.resolve_cluster 🔴 10/12 12/12
indices.resolve_index 🟢 6/6 6/6
indices.rollover 🔴 26/26 1/26
indices.segments 🔴 6/6 5/6
indices.shard_stores 🔴 5/5 4/5
indices.shrink 🟢 5/5 5/5
indices.simulate_index_template 🔴 6/7 5/7
indices.simulate_template 🔴 5/5 4/5
indices.split 🟢 11/11 11/11
indices.stats 🔴 113/113 30/112
indices.update_aliases 🔴 26/26 7/26
indices.validate_query 🟢 12/12 12/12

You can validate these APIs yourself by using the make validate target.

@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.add_block 🟢 2/2 2/2
indices.analyze 🟢 243/243 243/243
indices.cancel_migrate_reindex 🟢 2/2 2/2
indices.clear_cache 🟢 4/4 4/4
indices.clone 🟢 5/5 5/5
indices.close 🟢 49/49 49/49
indices.create_data_stream 🟢 31/31 31/31
indices.create_from 🟢 4/4 4/4
indices.create 🔴 961/1174 1174/1174
indices.data_streams_stats 🟢 4/4 4/4
indices.delete_alias 🔴 12/12 5/12
indices.delete_data_lifecycle ⚪ Missing test Missing test
indices.delete_data_stream 🟢 28/28 28/28
indices.delete_index_template 🟢 1/1 1/1
indices.delete_template 🟢 9/9 9/9
indices.delete 🟢 105/105 105/105
indices.disk_usage 🟢 6/6 6/6
indices.downsample 🟢 2/2 2/2
indices.exists_alias 🟢 37/37 37/37
indices.exists_index_template ⚪ Missing test Missing test
indices.exists_template 🟢 15/15 15/15
indices.exists 🟢 39/39 39/39
indices.explain_data_lifecycle ⚪ Missing test Missing test
indices.field_usage_stats 🟢 5/5 5/5
indices.flush 🟢 41/41 41/41
indices.forcemerge 🟢 12/12 12/12
indices.get_alias 🟢 68/68 68/68
indices.get_data_lifecycle_stats ⚪ Missing test Missing test
indices.get_data_lifecycle ⚪ Missing test Missing test
indices.get_data_stream 🟢 11/11 11/11
indices.get_field_mapping 🟢 15/15 15/15
indices.get_index_template 🔴 21/21 17/21
indices.get_mapping 🔴 135/135 133/135
indices.get_migrate_reindex_status 🟢 1/1 1/1
indices.get_settings 🔴 76/76 69/76
indices.get_template 🟢 32/32 32/32
indices.get 🔴 55/55 53/55
indices.migrate_reindex 🟢 2/2 2/2
indices.migrate_to_data_stream ⚪ Missing test Missing test
indices.modify_data_stream ⚪ Missing test Missing test
indices.open 🟢 20/20 20/20
indices.promote_data_stream ⚪ Missing test Missing test
indices.put_alias 🔴 58/58 20/58
indices.put_data_lifecycle ⚪ Missing test Missing test
indices.put_index_template 🔴 59/68 68/68
indices.put_mapping 🔴 111/117 117/117
indices.put_settings 🔴 55/58 58/58
indices.put_template 🔴 45/46 46/46
indices.recovery 🟢 9/9 9/9
indices.refresh 🟢 275/275 275/275
indices.reload_search_analyzers 🟢 2/2 2/2
indices.resolve_cluster 🔴 10/12 12/12
indices.resolve_index 🟢 6/6 6/6
indices.rollover 🔴 26/26 1/26
indices.segments 🔴 6/6 5/6
indices.shard_stores 🔴 5/5 4/5
indices.shrink 🟢 5/5 5/5
indices.simulate_index_template 🔴 6/7 5/7
indices.simulate_template 🔴 5/5 4/5
indices.split 🟢 11/11 11/11
indices.stats 🔴 113/113 30/112
indices.update_aliases 🔴 26/26 7/26
indices.validate_query 🟢 12/12 12/12

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta merged commit 94e5ff9 into main Jan 31, 2025
8 checks passed
@l-trotta l-trotta deleted the cap-source-mode-enum branch January 31, 2025 16:45
github-actions bot pushed a commit that referenced this pull request Jan 31, 2025
@l-trotta @github-actions
uppercase enum source mode (#3676)
8d9194d 
(cherry picked from commit 94e5ff9)
@github-actions github-actions bot mentioned this pull request Jan 31, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jan 31, 2025
@l-trotta @github-actions
uppercase enum source mode (#3676)
807edf2 
(cherry picked from commit 94e5ff9)
@github-actions github-actions bot mentioned this pull request Jan 31, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jan 31, 2025
@l-trotta @github-actions
uppercase enum source mode (#3676)
78775ea 
(cherry picked from commit 94e5ff9)
@github-actions github-actions bot mentioned this pull request Jan 31, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jan 31, 2025
@l-trotta @github-actions
uppercase enum source mode (#3676)
01a96ff 
(cherry picked from commit 94e5ff9)
@github-actions github-actions bot mentioned this pull request Jan 31, 2025
Merged
l-trotta added a commit that referenced this pull request Jan 31, 2025
@github-actions @l-trotta
uppercase enum source mode (#3676) (#3677)
774fa86 
(cherry picked from commit 94e5ff9)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Jan 31, 2025
@github-actions @l-trotta
uppercase enum source mode (#3676) (#3678)
38010a0 
(cherry picked from commit 94e5ff9)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Jan 31, 2025
@github-actions @l-trotta
uppercase enum source mode (#3676) (#3679)
ac1361f 
(cherry picked from commit 94e5ff9)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Jan 31, 2025
@github-actions @l-trotta
uppercase enum source mode (#3676) (#3680)
d2cf8aa 
(cherry picked from commit 94e5ff9)

Co-authored-by: Laura Trotta <[email protected]>
pquentin pushed a commit that referenced this pull request Feb 6, 2025
@flobernd @lcawl
@elasticmachine @l-trotta @davidkyle @masseyke @ymao1
Backport missing 9 (#3706)
318b62b 
* [DOCS] Fix overlay for resolve cluster (#3670)

* Update specification output

* uppercase enum source mode (#3676)

* [DOCS] Add overlays for CCR API examples (#3672)

* Update inference.update.json with the correct verb (#3688)

* Update specification output

* [DOCS] Convert final examples from JSON to YAML (#3692)

* Update specification output

* Correcting the response format for ingest simulate (#3640)

* Correcting the response format for ingest simulate

* code review feedback

* moving error to the correct place, and adding ignored_fields

* Update specification/simulate/ingest/SimulateIngestResponse.ts

Co-authored-by: Laura Trotta <[email protected]>

---------

Co-authored-by: Laura Trotta <[email protected]>

* Update specification output

* Add text_embedding_bits to inference result output (#3698)

* Update specification output

* Improve `Analyzer` definitions and fix various classes (#3215)

* Update specification output

---------

Co-authored-by: Lisa Cawley <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Laura Trotta <[email protected]>
Co-authored-by: David Kyle <[email protected]>
Co-authored-by: Keith Massey <[email protected]>
Co-authored-by: Ying Mao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flobernd flobernd flobernd approved these changes

@pquentin pquentin Awaiting requested review from pquentin

Assignees
No one assigned
Labels
backport 8.x backport 8.17 backport 8.18 backport 9.0 specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l-trotta @flobernd