Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate discovery-azure and rename it to discovery-azure-classic #19144

Closed
dadoonet opened this issue Jun 29, 2016 · 1 comment
Closed

Deprecate discovery-azure and rename it to discovery-azure-classic #19144

dadoonet opened this issue Jun 29, 2016 · 1 comment
Labels
discuss :Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure

Comments

@dadoonet
Copy link
Member

As discussed at elastic/elasticsearch-cloud-azure#91 (comment), we know that the current discovery-azure plugin only works with Azure Classic VMs / Services (which is somehow Legacy now).

The proposal here is to rename discovery-azure to discovery-azure-classic in case some users are using it.
And deprecate it for 5.0.

Note that the renaming already happened from 2.x to 5.0 because we split cloud-azure in 2 plugins:

  • discovery-azure
  • repository-azure

We can then work on a new discovery-azure-arm plugin if there is a need.

Another option could be to provide classic and ARM in the same discovery-azure plugin but this will mean that we will depend on multiple Azure SDK jars. Read https://github.com/Azure/azure-sdk-for-java/wiki/Azure-SDK-for-Java-Features
But I don't think we should do it as it could potentially lead us to some JAR conflicts.

@Mpdreamz
Copy link
Member

Would definitely prefer a clean split so we can easily phase out discovery-azure-classic when at such it time it makes sense to do so.

dadoonet added a commit to dadoonet/elasticsearch that referenced this issue Jun 30, 2016
As discussed at elastic/elasticsearch-cloud-azure#91 (comment), we know that the current `discovery-azure` plugin only works with Azure Classic VMs / Services (which is somehow Legacy now).

The proposal here is to rename `discovery-azure` to `discovery-azure-classic` in case some users are using it.
And deprecate it for 5.0.

Closes elastic#19144.
@clintongormley clintongormley added :Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure and removed :Plugin Discovery Azure Classic labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss :Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure
Projects
None yet
Development

No branches or pull requests

3 participants