Add support for Azure Resource Manager (ARM)

[dadoonet]

As explained in #19144 we could create a new plugin named discovery-azure-arm which is based on the newest versions of the Azure SDK.

Classic was based on private key / password which was bad for what we want to achieve with such a plugin.
ARM uses now key / secrets which are really much more flexible and safer.

Basically you can now write code like this example:

ComputeManagementClient client;

// Default environment, no credentials
client = new ComputeManagementClientImpl();

// Custom environment with AzureChinaCloud endpoint
String chinaCloudEndpoint = "https://management.chinacloudapi.cn/";
client = new ComputeManagementClientImpl(chinaCloudEndpoint);

// Default environment with credentials
ApplicationTokenCredentials credentials = new ApplicationTokenCredentials(
        "client-id", "tenant-id", "secret", null);
client = new ComputeManagementClientImpl(credentials);

// Custom environment with credentials
client = new ComputeManagementClientImpl(chinaCloudEndpoint, credentials);

// Fully customized, with HTTP client and Retrofit modifiable
client = new ComputeManagementClientImpl(
        chinaCloudEndpoint,
        credentials,
        new OkHttpClient.Builder(),
        new Retrofit.Builder());

[jpountz]

Looks like we should do it. @dadoonet is there anything to discuss here (it has the discuss label)?

[aslanbakirov]

@dadoonet It seems that you already started working on it. Is there a planned date for release?

[dadoonet]

No date sorry. I just can tell that this will happen only with 5.0 series or later. So won't be available for 2.x series.

[aslanbakirov]

We would like to contribute, can you publish the branch that you are working on,so we may continue with that?

[ejsmith]

Will this support using an Azure Scale Sets to discover member nodes?

[justinbarias]

Hello, any update on this piece of work? Or at least a placeholder plugin for the "azure-discovery-arm" plugin?

[JamieCressey]

+1 for this plugin

[synhershko]

@dadoonet what is the status of this? was this released and can be used with 5.x? Classic plugin has a deprecated warning but no ARM plugin seems to be available at this point?

[dadoonet]

@synhershko I made some progress recently on this at #22679.
Not ready yet. My plan is to have something ready for 6.x series.

In the meantime, if you want to use azure discovery you still need to use the classic version of the plugin even though it's deprecated.

[synhershko]

Problem is its useless if you use ARM for your deployment. Any chance this can be backported (and finished soon :) ) ?

…

On Jun 7, 2017 3:26 PM, "David Pilato" ***@***.***> wrote: @synhershko <https://github.com/synhershko> I made some progress recently on this at #22679 <#22679>. Not ready yet. My plan is to have something ready for 6.x series. In the meantime, if you want to use azure discovery you still need to use the classic version of the plugin even though it's deprecated. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19146 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAM9HNhhxMdrPxzyv9SdxFT8tYEgF14Uks5sBpb-gaJpZM4JBA0C> .

[dadoonet]

I don't think it will be ever backported when finished.

[ywelsch]

We had an internal discussion on this and, while generally useful, think that we currently cannot take this one on, in particular give it the proper testing, support and maintenance that we provide for the other plugins in the ES repo. This might be a better fit as a community plugin for now. As a clear indication that we're not going to work on this in the foreseeable future, I'm closing this issue.