Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request indexing memory pressure metrics in APM node metrics publisher #103520

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Request indexing memory pressure metrics in APM node metrics publisher #103520

merged 2 commits into from
Dec 18, 2023

Conversation

fcofdez
Copy link
Contributor

@fcofdez fcofdez commented Dec 18, 2023

Relates #103172

@fcofdez fcofdez added >bug :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Dec 18, 2023
@fcofdez fcofdez requested review from volodk85 and piergm December 18, 2023 16:27
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@fcofdez
Copy link
Contributor Author

fcofdez commented Dec 18, 2023

I think that we should add some testing for this class, otherwise it's easy to miss potential bugs that could be easily solved by testing.

@elasticsearchmachine
Copy link
Collaborator

Hi @fcofdez, I've created a changelog YAML for you.

@fcofdez fcofdez changed the title Request indexing memory pressure in APM node metrics publisher Request indexing memory pressure metrics in APM node metrics publisher Dec 18, 2023
volodk85
volodk85 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@volodk85 volodk85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fcofdez fcofdez merged commit 31145f7 into elastic:main Dec 18, 2023
@rjernst rjernst mentioned this pull request Dec 20, 2023
Merged
navarone-feekery pushed a commit to navarone-feekery/elasticsearch that referenced this pull request Dec 22, 2023
@fcofdez @navarone-feekery
Request indexing memory pressure metrics in APM node metrics publisher (
57bf624 
elastic#103520)

Relates elastic#103172
@pgomulka pgomulka mentioned this pull request Jan 12, 2024
Merged
pgomulka added a commit that referenced this pull request Jan 15, 2024
@pgomulka
Fix double registered metrics and chain getters throwing NPE #104306
293d030 
some of the metrics were accidentaly registered under the same name and were logging errors in apm agent logs (#103388)
also there were nullpointers in apm agent logs, the chained getters were replaced to use an optional
the fix in #103520 does not helped with NPEs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxsalehi pxsalehi pxsalehi approved these changes

@volodk85 volodk85 volodk85 approved these changes

@piergm piergm Awaiting requested review from piergm

Assignees
No one assigned
Labels
>bug :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fcofdez @elasticsearchmachine @pxsalehi @volodk85