Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated fielddata_fields from search request #25566

Merged
merged 1 commit into from
Jul 6, 2017

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Jul 6, 2017

This PR fix the changes in #25537 to remove the fielddata_fields entirely from 6.0 on.

/cc @colings86 I had some time this working to extend the PR you've started so I hope you don't mind reviewing this one instead ;)

@jimczi jimczi added :Search/Search Search-related issues that do not fall into other categories >breaking review labels Jul 6, 2017
@jimczi jimczi requested a review from colings86 July 6, 2017 06:44
Copy link
Contributor

@colings86 colings86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for picking this up @jimczi

@jimczi jimczi added the v6.0.0 label Jul 6, 2017
jimczi added a commit that referenced this pull request Jul 6, 2017
@jimczi jimczi merged commit 31614c3 into elastic:master Jul 6, 2017
@jimczi jimczi deleted the fielddata_fields_removal branch July 6, 2017 11:02
Mpdreamz added a commit to elastic/elasticsearch-net that referenced this pull request Oct 11, 2017
Mpdreamz added a commit to elastic/elasticsearch-net that referenced this pull request Oct 21, 2017
Mpdreamz added a commit to elastic/elasticsearch-net that referenced this pull request Oct 21, 2017
Mpdreamz added a commit to elastic/elasticsearch-net that referenced this pull request Nov 16, 2017
Mpdreamz added a commit to elastic/elasticsearch-net that referenced this pull request Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Search/Search Search-related issues that do not fall into other categories v6.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants