add awaitsfixed tests for running ILM actions during snapshot #37552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talevy
added
>test
|
Pinging @elastic/es-core-features |
talevy
force-pushed
the
ilm-snapshot-test
branch
from
e2eca9f to
7aeec21
Compare
|
fun fact: not all |
dakrone
approved these changes
Jan 17, 2019
...-node/src/test/java/org/elasticsearch/xpack/indexlifecycle/TimeSeriesLifecycleActionsIT.java
Show resolved
Hide resolved
talevy
changed the title
|
run gradle build tests 1 |
|
run gradle build tests 1 |
|
run gradle build tests 2 |
|
run gradle build tests 1 |
|
run gradle build tests 1 |
|
These tests were designed to be used by a follow-up PR that fixes these ILM action while snapshot issues. Closing this since changes to these tests will need to be done when new code for fixes are introduced. This PR can be viewed as a reference to tests that will be added in other PRs. Closing to be superseded by follow-up PRs |
dakrone
added a commit
that referenced
this pull request
Jan 23, 2019
Some steps, such as steps that delete, close, or freeze an index, may fail due to a currently running snapshot of the index. In those cases, rather than move to the ERROR step, we should retry the step when the snapshot has completed. This change adds an abstract step (`AsyncRetryDuringSnapshotActionStep`) that certain steps (like the ones I mentioned above) can extend that will automatically handle a situation where a snapshot is taking place. When a `SnapshotInProgressException` is received by the listener wrapper, a `ClusterStateObserver` listener is registered to wait until the snapshot has completed, re-running the ILM action when no snapshot is occurring. This also adds integration tests for these scenarios (thanks to @talevy in #37552). Resolves #37541
dakrone
added a commit
that referenced
this pull request
Jan 23, 2019
Some steps, such as steps that delete, close, or freeze an index, may fail due to a currently running snapshot of the index. In those cases, rather than move to the ERROR step, we should retry the step when the snapshot has completed. This change adds an abstract step (`AsyncRetryDuringSnapshotActionStep`) that certain steps (like the ones I mentioned above) can extend that will automatically handle a situation where a snapshot is taking place. When a `SnapshotInProgressException` is received by the listener wrapper, a `ClusterStateObserver` listener is registered to wait until the snapshot has completed, re-running the ILM action when no snapshot is occurring. This also adds integration tests for these scenarios (thanks to @talevy in #37552). Resolves #37541
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests check that Delete, Freeze, and Shrink actions fail execution while
a snapshot is in progress.
these should stay awaitsfixed until #37541 is resolved.
The intention of this PR is to introduce tests that should pass once follow-up PRs are introduced that can un-awaits them.