[ML] address two edge cases for categorization.GrokPatternCreator#findBestGrokMatchFromExamples #51168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dBestGrokMatchFromExamples
|
Pinging @elastic/ml-core (:ml) |
|
run elasticsearch-ci/bwc |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
benwtrent
deleted the
feature/ml-fix-category-grok-pattern-creator-bugs
branch
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Jan 21, 2020
…dBestGrokMatchFromExamples (elastic#51168) There are two edge cases that can be ran into when example input is matched in a weird way. 1. Recursion depth could continue many many times, resulting in a HUGE runtime cost. I put a limit of 10 recursions (could be adjusted I suppose). 2. If there are no "fixed regex bits", exploring the grok space would result in a fence-post error during runtime (with assertions turned off)
benwtrent
added a commit
that referenced
this pull request
Jan 21, 2020
…dBestGrokMatchFromExamples (#51168) (#51255) There are two edge cases that can be ran into when example input is matched in a weird way. 1. Recursion depth could continue many many times, resulting in a HUGE runtime cost. I put a limit of 10 recursions (could be adjusted I suppose). 2. If there are no "fixed regex bits", exploring the grok space would result in a fence-post error during runtime (with assertions turned off)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two edge cases that can be ran into when example input is matched in a weird way.