Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [ML] address two edge cases for categorization.GrokPatternCreator#findBestGrokMatchFromExamples (#51168) #51255

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

benwtrent
Copy link
Member

Backports the following commits to 7.x:

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…dBestGrokMatchFromExamples (elastic#51168)

There are two edge cases that can be ran into when example input is matched in a weird way.

1. Recursion depth could continue many many times, resulting in a HUGE runtime cost. I put a limit of 10 recursions (could be adjusted I suppose). 
2. If there are no "fixed regex bits", exploring the grok space would result in a fence-post error during runtime (with assertions turned off)
@benwtrent benwtrent added :ml Machine learning backport labels Jan 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@benwtrent benwtrent merged commit a9b2bc5 into elastic:7.x Jan 21, 2020
@benwtrent benwtrent deleted the backport/7.x/pr-51168 branch January 21, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport :ml Machine learning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants