-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add REST API for ComponentTemplate CRUD #53558
Add REST API for ComponentTemplate CRUD #53558
Conversation
This adds the Put/Get/DeleteComponentTemplate APIs that allow inserting, retrieving, and removing ComponentTemplateMetadata into the cluster state metadata. These APIs are currently only available behind a feature flag system property - `es.itv2_feature_flag_registered`. Relates to elastic#53101
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few small comments, otherwise LGTM
...va/org/elasticsearch/action/admin/indices/template/delete/DeleteComponentTemplateAction.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/MetaDataIndexTemplateService.java
Outdated
Show resolved
Hide resolved
...n/java/org/elasticsearch/action/admin/indices/template/get/GetComponentTemplateResponse.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments from my side, otherwise LGTM 👍
...in/java/org/elasticsearch/action/admin/indices/template/get/GetComponentTemplateRequest.java
Outdated
Show resolved
Hide resolved
...in/java/org/elasticsearch/action/admin/indices/template/get/GetComponentTemplateRequest.java
Outdated
Show resolved
Hide resolved
...org/elasticsearch/action/admin/indices/template/get/TransportGetComponentTemplateAction.java
Outdated
Show resolved
Hide resolved
...in/java/org/elasticsearch/action/admin/indices/template/put/PutComponentTemplateRequest.java
Outdated
Show resolved
Hide resolved
@elasticmachine update branch |
@elasticmachine update branch |
@elasticmachine update branch |
* Add REST API for ComponentTemplate CRUD This adds the Put/Get/DeleteComponentTemplate APIs that allow inserting, retrieving, and removing ComponentTemplateMetadata into the cluster state metadata. These APIs are currently only available behind a feature flag system property - `es.itv2_feature_flag_registered`. Relates to elastic#53101 Co-authored-by: Elastic Machine <[email protected]>
* Add REST API for ComponentTemplate CRUD This adds the Put/Get/DeleteComponentTemplate APIs that allow inserting, retrieving, and removing ComponentTemplateMetadata into the cluster state metadata. These APIs are currently only available behind a feature flag system property - `es.itv2_feature_flag_registered`. Relates to #53101 Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
The following API spec files contain a link to a not-yet-created docs page for the data stream APIs: * [indices.create_data_stream.json][0] * [indices.delete_data_stream.jsonn][1] * [indices.get_data_streams.json][2] The Elaticsearch-JS client uses these spec files to create their docs. This created a broken link in the Elaticsearch-JS, which has broken the docs build. This PR adds a temporary redirect for the docs page. This redirect should be removed when the actual API docs are added. [0]: https://github.com/elastic/elasticsearch/blob/master/rest-api-spec/src/main/resources/rest-api-spec/api/indices.create_data_stream.json [1]: https://github.com/elastic/elasticsearch/blob/master/rest-api-spec/src/main/resources/rest-api-spec/api/indices.delete_data_stream.json [2]: https://github.com/elastic/elasticsearch/blob/master/rest-api-spec/src/main/resources/rest-api-spec/api/indices.get_data_streams.json Relates to #53558. CC @martijnvg
The following API spec files contain a link to a not-yet-created docs page for the data stream APIs: * [indices.create_data_stream.json][0] * [indices.delete_data_stream.jsonn][1] * [indices.get_data_streams.json][2] The Elaticsearch-JS client uses these spec files to create their docs. This created a broken link in the Elaticsearch-JS, which has broken the docs build. This PR adds a temporary redirect for the docs page. This redirect should be removed when the actual API docs are added. [0]: https://github.com/elastic/elasticsearch/blob/master/rest-api-spec/src/main/resources/rest-api-spec/api/indices.create_data_stream.json [1]: https://github.com/elastic/elasticsearch/blob/master/rest-api-spec/src/main/resources/rest-api-spec/api/indices.delete_data_stream.json [2]: https://github.com/elastic/elasticsearch/blob/master/rest-api-spec/src/main/resources/rest-api-spec/api/indices.get_data_streams.json Relates to #53558. CC @martijnvg
This adds the Put/Get/DeleteComponentTemplate APIs that allow inserting, retrieving, and removing
ComponentTemplateMetadata into the cluster state metadata.
These APIs are currently only available behind a feature flag system property -
es.itv2_feature_flag_registered
.Relates to #53101