-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ESRestTestCase#getAllUnexpectedTemplates() to remove v2 style templates if nodes are in 7.8.0 or later #80330
Conversation
… /composable index templates if nodes are in 7.8.0 or later. Composable index templates were introduced in 7.8.0 and component templates in 7.7.0 (but not the rest action iirc). Some bwc tests fail during teardown, because APIs get invoked that don't exist in particular versions.3 Closes elastic#80323 elastic#80322
Pinging @elastic/es-data-management (Team:Data Management) |
@elasticmachine run elasticsearch-ci/full-bwc |
Pinging @elastic/clients-team (Team:Clients) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
component templates in 7.7.0 (but not the rest action iirc)
It seems the REST APIs are introduced by #53558 which is released in 7.7.0. If that's the case, should we only guard the _index_template
API with the 7.8.0
version constant and keep using 7.7.0
for the _component_template
calls?
In that version, the component template APIs were behind a feature flag, so they aren't usable. So I think the if statement should stay like it is now. |
…templates if nodes are in 7.8.0 or later (#80342) Composable index templates were introduced in 7.8.0 and component templates in 7.7.0 (but not the rest action iirc). Forwardport #80330 to 8.0 Some bwc tests fail during teardown, because APIs get invoked that don't exist in particular versions. I will forward port this to 8.0 and master branches if build is successful (including full bwc tests). Closes #80323, #80322
The issue with template cleanup that broke this test was fixed in elastic#80330 now so we can unmute here. closes elastic#80088
The issue with template cleanup that broke this test was fixed in elastic#80330 now so we can unmute here. closes elastic#80088
Composable index templates were introduced in 7.8.0 and component templates in 7.7.0 (but not the rest action iirc).
Some bwc tests fail during teardown,
because APIs get invoked that don't exist
in particular versions.
I will forward port this to 8.0 and master branches if build is successful (including full bwc tests).
Closes #80323 #80322