Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ESRestTestCase#getAllUnexpectedTemplates() to remove v2 style templates if nodes are in 7.8.0 or later #80330

Conversation

martijnvg
Copy link
Member

Composable index templates were introduced in 7.8.0 and component templates in 7.7.0 (but not the rest action iirc).

Some bwc tests fail during teardown,
because APIs get invoked that don't exist
in particular versions.

I will forward port this to 8.0 and master branches if build is successful (including full bwc tests).

Closes #80323 #80322

… /composable index templates if nodes are in 7.8.0 or later.

Composable index templates were introduced in 7.8.0 and component templates in 7.7.0 (but not the rest action iirc).

Some bwc tests fail during teardown,
because APIs get invoked that don't exist
in particular versions.3

Closes elastic#80323 elastic#80322
@martijnvg martijnvg added >test Issues or PRs that are addressing/adding tests :Data Management/Indices APIs APIs to create and manage indices and templates v8.0.0 test-full-bwc Trigger full BWC version matrix tests v7.16.1 v8.1.0 labels Nov 4, 2021
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Nov 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@martijnvg
Copy link
Member Author

@elasticmachine run elasticsearch-ci/full-bwc

@martijnvg martijnvg requested review from ywangd and masseyke November 4, 2021 11:01
@sethmlarson sethmlarson added the Team:Clients Meta label for clients team label Nov 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

component templates in 7.7.0 (but not the rest action iirc)

It seems the REST APIs are introduced by #53558 which is released in 7.7.0. If that's the case, should we only guard the _index_template API with the 7.8.0 version constant and keep using 7.7.0 for the _component_template calls?

@martijnvg
Copy link
Member Author

It seems the REST APIs are introduced by #53558 which is released in 7.7.0. If that's the case, should we only guard the _index_template API with the 7.8.0 version constant and keep using 7.7.0 for the _component_template calls?

In that version, the component template APIs were behind a feature flag, so they aren't usable. So I think the if statement should stay like it is now.

@martijnvg martijnvg merged commit 32e8f33 into elastic:7.16 Nov 4, 2021
martijnvg added a commit that referenced this pull request Nov 4, 2021
…templates if nodes are in 7.8.0 or later (#80342)

Composable index templates were introduced in 7.8.0 and component templates in 7.7.0 (but not the rest action iirc).

Forwardport #80330 to 8.0

Some bwc tests fail during teardown,
because APIs get invoked that don't exist
in particular versions.

I will forward port this to 8.0 and master branches if build is successful (including full bwc tests).

Closes #80323, #80322
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jan 12, 2022
The issue with template cleanup that broke this test was fixed in elastic#80330 now
so we can unmute here.

closes elastic#80088
original-brownbear added a commit that referenced this pull request Jan 13, 2022
The issue with template cleanup that broke this test was fixed in #80330 now
so we can unmute here.

closes #80088
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jan 13, 2022
The issue with template cleanup that broke this test was fixed in elastic#80330 now
so we can unmute here.

closes elastic#80088
elasticsearchmachine pushed a commit that referenced this pull request Jan 13, 2022
The issue with template cleanup that broke this test was fixed in #80330 now
so we can unmute here.

closes #80088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates Team:Clients Meta label for clients team Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests test-full-bwc Trigger full BWC version matrix tests v7.16.0 v8.0.0-rc1 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants