Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent putting V2 index template when overlapping with existing template #54933

Merged

Conversation

probakowski
Copy link
Contributor

This change prevents putting V2 index template when it would overlap with existing V2 template of the same priority

Relates to #53101

…late

This change prevents putting V2 index template when it would overlap with existing V2 template
of the same priority

Relates to elastic#53101
@probakowski probakowski requested a review from dakrone April 7, 2020 23:14
@martijnvg martijnvg mentioned this pull request Apr 7, 2020
39 tasks
@probakowski probakowski added :Data Management/Indices APIs APIs to create and manage indices and templates >non-issue v7.8.0 v8.0.0 labels Apr 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Indices APIs)

@probakowski
Copy link
Contributor Author

@elasticmachine update branch

@probakowski
Copy link
Contributor Author

@elasticmachine update branch

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks Przemko! I left a few minor suggestions but nothing that needs more reviewing

@probakowski
Copy link
Contributor Author

@elasticmachine update branch

@probakowski
Copy link
Contributor Author

@elasticmachine test this please

@probakowski
Copy link
Contributor Author

@elasticmachine update branch

@probakowski probakowski merged commit e348959 into elastic:master Apr 10, 2020
@probakowski probakowski deleted the prevent-overlapping-v2-templates branch April 10, 2020 05:56
probakowski added a commit to probakowski/elasticsearch that referenced this pull request Apr 10, 2020
…late (elastic#54933)

* Prevent putting V2 index template when overlapping with existing template

This change prevents putting V2 index template when it would overlap with existing V2 template
of the same priority

Relates to elastic#53101
probakowski added a commit that referenced this pull request Apr 10, 2020
…late (#54933) (#55042)

* Prevent putting V2 index template when overlapping with existing template

This change prevents putting V2 index template when it would overlap with existing V2 template
of the same priority

Relates to #53101
probakowski added a commit to probakowski/elasticsearch that referenced this pull request Apr 21, 2020
This change fixes problem with updating Index Templates V2.
Validatation added in elastic#54933 didn't filter list of conflicting templates correctly so
new template was always clashing with itself unless patterns were not changed completely.
probakowski added a commit that referenced this pull request Apr 22, 2020
This change fixes problem with updating Index Templates V2.
Validatation added in #54933 didn't filter list of conflicting templates correctly so
new template was always clashing with itself unless patterns were not changed completely.
probakowski added a commit to probakowski/elasticsearch that referenced this pull request Apr 22, 2020
This change fixes problem with updating Index Templates V2.
Validatation added in elastic#54933 didn't filter list of conflicting templates correctly so
new template was always clashing with itself unless patterns were not changed completely.
probakowski added a commit that referenced this pull request Apr 22, 2020
This change fixes problem with updating Index Templates V2.
Validatation added in #54933 didn't filter list of conflicting templates correctly so
new template was always clashing with itself unless patterns were not changed completely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >non-issue v7.8.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants