-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent putting V2 index template when overlapping with existing template #54933
Prevent putting V2 index template when overlapping with existing template #54933
Conversation
…late This change prevents putting V2 index template when it would overlap with existing V2 template of the same priority Relates to elastic#53101
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
This reverts commit 9f3732a.
@elasticmachine update branch |
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks Przemko! I left a few minor suggestions but nothing that needs more reviewing
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateService.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateServiceTests.java
Outdated
Show resolved
Hide resolved
@elasticmachine update branch |
…taIndexTemplateService.java Co-Authored-By: Lee Hinman <[email protected]>
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateService.java
Show resolved
Hide resolved
@elasticmachine test this please |
@elasticmachine update branch |
…late (elastic#54933) * Prevent putting V2 index template when overlapping with existing template This change prevents putting V2 index template when it would overlap with existing V2 template of the same priority Relates to elastic#53101
This change fixes problem with updating Index Templates V2. Validatation added in elastic#54933 didn't filter list of conflicting templates correctly so new template was always clashing with itself unless patterns were not changed completely.
This change fixes problem with updating Index Templates V2. Validatation added in #54933 didn't filter list of conflicting templates correctly so new template was always clashing with itself unless patterns were not changed completely.
This change fixes problem with updating Index Templates V2. Validatation added in elastic#54933 didn't filter list of conflicting templates correctly so new template was always clashing with itself unless patterns were not changed completely.
This change prevents putting V2 index template when it would overlap with existing V2 template of the same priority
Relates to #53101