Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updating Index Templates V2 #55556

Merged

Conversation

probakowski
Copy link
Contributor

This change fixes problem with updating Index Templates V2.
Validation added in #54933 didn't filter list of conflicting templates correctly so new template was always clashing with itself unless patterns were not changed completely.

This change fixes problem with updating Index Templates V2.
Validatation added in elastic#54933 didn't filter list of conflicting templates correctly so
new template was always clashing with itself unless patterns were not changed completely.
@probakowski probakowski added :Data Management/Indices APIs APIs to create and manage indices and templates v8.0.0 v7.8.0 labels Apr 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Indices APIs)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this quickly @probakowski!

@probakowski probakowski merged commit de7915b into elastic:master Apr 22, 2020
@probakowski probakowski deleted the fix-updating-index-templates-v2 branch April 22, 2020 16:54
probakowski added a commit to probakowski/elasticsearch that referenced this pull request Apr 22, 2020
This change fixes problem with updating Index Templates V2.
Validatation added in elastic#54933 didn't filter list of conflicting templates correctly so
new template was always clashing with itself unless patterns were not changed completely.
probakowski added a commit that referenced this pull request Apr 22, 2020
This change fixes problem with updating Index Templates V2.
Validatation added in #54933 didn't filter list of conflicting templates correctly so
new template was always clashing with itself unless patterns were not changed completely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >non-issue v7.8.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants