[ML] modularize x-pack plugins ml and autoscaling #95057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add module-info.java files for x-pack plugins ml and autoscaling
|
Pinging @elastic/ml-core (Team:ML) |
droberts195
reviewed
Apr 5, 2023
droberts195
reviewed
Apr 5, 2023
Comment on lines
1
to
7
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
| * in compliance with, at your election, the Elastic License 2.0 or the Server | ||
| * Side Public License, v 1. | ||
| */ |
There was a problem hiding this comment.
This is the wrong license header - it mentions SSPL which is not an alternative for X-Pack files.
It should be the same license header as the other file in this PR.
droberts195
reviewed
Apr 5, 2023
|
Hi @edsavage, I've created a changelog YAML for you. |
… modularize_xpack_plugin_ml
Attempt to fix current verification failures. There may be more to come.
droberts195
reviewed
Apr 6, 2023
| @@ -16,6 +16,10 @@ | |||
| public class MlAutoscalingExtension implements AutoscalingExtension { | |||
| private final MachineLearning plugin; | |||
|
|
|||
| public MlAutoscalingExtension() { | |||
| this.plugin = null; | |||
There was a problem hiding this comment.
Please do it like this:
Otherwise, if anyone did ever call this constructor they'd be setting up a subsequent null pointer exception.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 10, 2023
In elastic#95057 we turned ML into a proper module, but omitted a `requires` directive that IntelliJ reports as a compilation error. This commit adds the missing directive.
DaveCTurner
added a commit
that referenced
this pull request
Apr 11, 2023
In #95057 we turned ML into a proper module, but omitted a `requires` directive that IntelliJ reports as a compilation error. This commit adds the missing directive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add module-info.java files for x-pack plugins ml and autoscaling.
A slight restructure was needed to place the
exact.propertiesresource file into a path name corresponding to a package name. Theutilspackage was chosen as the resource file is required by theDomainSplitFunctionclass residing there.