Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IntelliJ compilation #95108

Merged

Conversation

DaveCTurner
Copy link
Contributor

In #95057 we turned ML into a proper module, but omitted a requires directive that IntelliJ reports as a compilation error. This commit adds the missing directive.

In elastic#95057 we turned ML into a proper module, but omitted a `requires`
directive that IntelliJ reports as a compilation error. This commit adds
the missing directive.
@DaveCTurner DaveCTurner requested a review from edsavage April 10, 2023 15:34
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Apr 10, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit 09d28a6 into elastic:main Apr 11, 2023
@DaveCTurner DaveCTurner deleted the 2023-04-10-ml-intellij-compile branch April 11, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning >non-issue Team:ML Meta label for the ML team v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants