Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build multiarch Docker images #197

Merged
merged 15 commits into from
May 16, 2022

Conversation

kuisathaverat
Copy link
Contributor

@kuisathaverat kuisathaverat commented May 12, 2022

it builds the base image for linux/amd64 and linux/arm64, the push is delegated to buildx, this push the manifest for the two platforms

related to #153

@kuisathaverat kuisathaverat added enhancement New feature or request Team:Automation Label for the Observability productivity team labels May 12, 2022
@kuisathaverat kuisathaverat requested review from a team May 12, 2022 18:20
@kuisathaverat kuisathaverat self-assigned this May 12, 2022
@mergify
Copy link

mergify bot commented May 12, 2022

This pull request does not have a backport label. Could you fix it @kuisathaverat? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d is the label to automatically backport to the 1./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@elasticmachine
Copy link

elasticmachine commented May 12, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-16T10:23:05.584+0000

  • Duration: 36 min 6 sec

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kuisathaverat
Copy link
Contributor Author

/test

docker buildx use multibuilder
docker buildx inspect --bootstrap
# echo 'Docker login ${DOCKER_REGISTRY}'
# docker login ${DOCKER_REGISTRY}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to give a second round on this, but in a follow up PR, because of that it si commented.

go/base/install-go.sh Outdated Show resolved Hide resolved
go/base/install-go.sh Outdated Show resolved Hide resolved
go/base/Makefile Outdated Show resolved Hide resolved
@kuisathaverat kuisathaverat merged commit 91d03ba into elastic:main May 16, 2022
@v1v v1v mentioned this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip enhancement New feature or request Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants