[O11y][Prometheus] Revert changes of TSDB performance and storage reduction #10766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agithomas
reviewed
Aug 19, 2024
| @@ -2,10 +2,14 @@ | |||
| type: group | |||
| fields: | |||
| - name: labels.* | |||
| type: object | |||
There was a problem hiding this comment.
Let us not do this rollback change.
Introducing labels_fingerprint would suffice
There was a problem hiding this comment.
What we have presently (as below), must be retained.
- name: prometheus
type: group
fields:
- name: labels.*
type: keyword
dimension: true
description: |
Prometheus metric labels
There was a problem hiding this comment.
Updated, thanks!
agithomas
reviewed
Aug 19, 2024
| @@ -2,10 +2,14 @@ | |||
| type: group | |||
| fields: | |||
| - name: labels.* | |||
| type: object | |||
There was a problem hiding this comment.
As mentioned above, let us not do this mapping changes.
Introducing labels_fingerprint is sufficient.
There was a problem hiding this comment.
Updated, thanks!
agithomas
reviewed
Aug 19, 2024
Co-authored-by: Agi K Thomas <[email protected]>
andrewkroh
added
Team:Cloudnative-Monitoring
agithomas
changed the title
constanca-m
approved these changes
Aug 21, 2024
felixbarny
reviewed
Aug 21, 2024
💚 Build Succeeded
History
|
|
felixbarny
approved these changes
Aug 22, 2024
|
Package prometheus - 1.18.1 containing this change is available at https://epr.elastic.co/search?package=prometheus |
4 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Related issues