[AWS] Eliminate dimensions fingerprint #10890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
enhancement
🚀 Benchmarks reportTo see the full report comment with |
|
💚 Build Succeeded
|
|
Hi @kaiyan-sheng, We faced a recent issue with rollover in prometheus package where all metrics getting dropped. We had to revert a similar change: #10766. |
|
Thanks @lalit-satapathy I will close this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Since 8.14.0 we can mark dimensions field as a dimension directly without having to use the fingerprint processor. Issue was fixed in elastic/elasticsearch#93564.
Please see #9910 for more details.
Checklist
changelog.ymlfile.