Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update O365 readme file #3026

Closed
wants to merge 21 commits into from
Closed

Update O365 readme file #3026

wants to merge 21 commits into from

Conversation

GinnyGalicia
Copy link
Contributor

@GinnyGalicia GinnyGalicia commented Apr 7, 2022 •
edited
Loading

Type of change

  • Enhancement

What does this PR do?

Tidy up of Markdown in. Readme.md, including adding link todeveloper's documentation, if missing

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

GinnyGalicia and others added 15 commits March 10, 2022 13:27
@GinnyGalicia
Update README.md
17bf8c1 
Changed headings to correct markdown syntax
@dependabot
Bump github.com/stretchr/testify from 1.7.0 to 1.7.1
0b2fc35 
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.7.0...v1.7.1)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@GinnyGalicia
Markdown tidy up of readme file
cd6e46d 
Markdown tidy up of readme file
@GinnyGalicia
Update readme
e9aad4e 
To avoid clashes
@GinnyGalicia
update to reset main
07f3de3 
update to reset main branch and stop files being added to PRs
@GinnyGalicia
reset to main build
fb2f512
@dependabot
Bump github.com/elastic/package-registry from 1.7.0 to 1.8.0
fc18bec 
Bumps [github.com/elastic/package-registry](https://github.com/elastic/package-registry) from 1.7.0 to 1.8.0.
- [Release notes](https://github.com/elastic/package-registry/releases)
- [Changelog](https://github.com/elastic/package-registry/blob/main/CHANGELOG.md)
- [Commits](elastic/package-registry@v1.7.0...v1.8.0)

---
updated-dependencies:
- dependency-name: github.com/elastic/package-registry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@GinnyGalicia
Merge pull request #6 from GinnyGalicia/dependabot/go_modules/github.…
f7759ab 
…com/elastic/package-registry-1.8.0

Bump github.com/elastic/package-registry from 1.7.0 to 1.8.0
@GinnyGalicia
Merge pull request #2 from GinnyGalicia/dependabot/go_modules/github.…
f675166 
…com/stretchr/testify-1.7.1

Bump github.com/stretchr/testify from 1.7.0 to 1.7.1
@dependabot
Bump github.com/magefile/mage from 1.11.0 to 1.13.0
52b1559 
Bumps [github.com/magefile/mage](https://github.com/magefile/mage) from 1.11.0 to 1.13.0.
- [Release notes](https://github.com/magefile/mage/releases)
- [Changelog](https://github.com/magefile/mage/blob/master/.goreleaser.yml)
- [Commits](magefile/mage@v1.11.0...v1.13.0)

---
updated-dependencies:
- dependency-name: github.com/magefile/mage
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@GinnyGalicia
Merge pull request #3 from GinnyGalicia/dependabot/go_modules/github.…
101ca85 
…com/magefile/mage-1.13.0

Bump github.com/magefile/mage from 1.11.0 to 1.13.0
@dependabot
Bump github.com/elastic/elastic-package from 0.38.0 to 0.46.0
0e2b24c 
Bumps [github.com/elastic/elastic-package](https://github.com/elastic/elastic-package) from 0.38.0 to 0.46.0.
- [Release notes](https://github.com/elastic/elastic-package/releases)
- [Changelog](https://github.com/elastic/elastic-package/blob/main/.goreleaser.yml)
- [Commits](elastic/elastic-package@v0.38.0...v0.46.0)

---
updated-dependencies:
- dependency-name: github.com/elastic/elastic-package
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@GinnyGalicia
Merge pull request #7 from GinnyGalicia/dependabot/go_modules/github.…
0490a16 
…com/elastic/elastic-package-0.46.0

Bump github.com/elastic/elastic-package from 0.38.0 to 0.46.0
@GinnyGalicia
Merge branch 'elastic:main' into main
18608b9
@GinnyGalicia
update readme
791475f 
Tidy up of Markdown in Readme.md, including adding link to developer's documentation, if missing
@GinnyGalicia GinnyGalicia requested a review from a team as a code owner April 7, 2022 11:42
@elasticmachine
Copy link

elasticmachine commented Apr 7, 2022 •
edited
Loading

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-18T13:27:32.648+0000

  • Duration: 3 min 37 sec

Steps errors 2

Expand to view the steps failures

Google Storage Download
  • Took 0 min 0 sec . View more details here
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/GinnyGalicia return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/GinnyGalicia : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/GinnyGalicia : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@r00tu53r r00tu53r added documentation Improvements or additions to documentation Team:Security-External Integrations Integration:o365 Microsoft Office 365 labels Apr 12, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
Copy link
Contributor

efd6 commented Apr 12, 2022

/test

@efd6
Copy link
Contributor

efd6 commented Apr 13, 2022

/test

r00tu53r
r00tu53r reviewed Apr 19, 2022
View reviewed changes
Copy link
Contributor

@r00tu53r r00tu53r left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field level doc changes shouldn't be part of this PR as there were no changes related to those. Please refer to my comment here and here. Please apply those steps and rebuild. This might have to be applied to the other open PRs too as I see similar changes there.

@ellis-elastic
Copy link
Contributor

Created a new PR so it's under ellis-elastic. #3531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 left review comments

@r00tu53r r00tu53r r00tu53r left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation Integration:o365 Microsoft Office 365
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GinnyGalicia @elasticmachine @efd6 @ellis-elastic @r00tu53r