Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update O365 readme file #3531

Merged
merged 6 commits into from
Aug 4, 2022
Merged

Update O365 readme file #3531

merged 6 commits into from
Aug 4, 2022

Conversation

ellis-elastic
Copy link
Contributor

@ellis-elastic ellis-elastic commented Jun 20, 2022 •
edited
Loading

added link to Microsoft documentation

  • Enhancement

What does this PR do?

added link to Microsoft documentation

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ellis-elastic
update readme
57e9a33 
added link to Microsoft documentation
@ellis-elastic ellis-elastic added documentation Improvements or additions to documentation enhancement New feature or request Team:Security-External Integrations Integration:o365 Microsoft Office 365 labels Jun 20, 2022
@ellis-elastic ellis-elastic requested a review from a team as a code owner June 20, 2022 09:02
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@ellis-elastic
update changelog
24bd53e 
fixed incorrect PR  number
@ellis-elastic ellis-elastic mentioned this pull request Jun 20, 2022
Closed
4 tasks
@elasticmachine
Copy link

elasticmachine commented Jun 20, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-04T09:14:15.660+0000

  • Duration: 15 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

efd6
efd6 previously requested changes Jun 21, 2022
View reviewed changes
packages/o365/changelog.yml Outdated Show resolved Hide resolved
@andrewkroh andrewkroh requested a review from efd6 July 20, 2022 16:53
@elasticmachine
Copy link

elasticmachine commented Jul 20, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.947
Classes 100.0% (1/1) 💚 2.947
Methods 100.0% (15/15) 💚 10.12
Lines 82.054% (727/886) 👎 -9.43
Conditionals 100.0% (0/0) 💚

@bmorelli25 bmorelli25 changed the base branch from main to aws-doc-updates July 29, 2022 17:51
@bmorelli25 bmorelli25 changed the base branch from aws-doc-updates to main July 29, 2022 17:52
@bmorelli25 bmorelli25 dismissed efd6’s stale review July 29, 2022 17:52

older review

@ellis-elastic ellis-elastic merged commit a785b0b into elastic:main Aug 4, 2022
@ellis-elastic ellis-elastic deleted the office365 branch August 4, 2022 10:11
@andrewkroh andrewkroh mentioned this pull request Aug 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@efd6 efd6 Awaiting requested review from efd6

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request Integration:o365 Microsoft Office 365
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ellis-elastic @elasticmachine @andrewkroh @efd6