Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] [CNVM] Added mappings to vulnerability #5915

Merged
merged 5 commits into from
Apr 19, 2023

Conversation

kfirpeled
Copy link
Contributor

What does this PR do?

Added field mapping to vulnerability and data views

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@kfirpeled kfirpeled added bug Something isn't working, use only for issues Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture] labels Apr 18, 2023
@kfirpeled kfirpeled requested review from jeniawhite and opauloh April 18, 2023 21:27
@kfirpeled kfirpeled requested a review from a team as a code owner April 18, 2023 21:27
@elasticmachine
Copy link

elasticmachine commented Apr 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-19T21:18:21.108+0000

  • Duration: 15 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 18, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.043
Classes 100.0% (0/0) 💚 3.043
Methods 25.0% (2/8) 👎 -66.655
Lines 100.0% (0/0) 💚 7.992
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just comments that can be addressed later

Comment on lines +12 to +16
- name: data_source.ID
type: keyword
- name: data_source.URL
type: keyword
- name: data_source.Name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still have time to convert those fields to lowercase?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @elastic/cloudbeat should answer this

cc: @oren-zohar , @olegsu , @jeniawhite

@kfirpeled kfirpeled merged commit daf7959 into elastic:main Apr 19, 2023
@kfirpeled kfirpeled deleted the cnvm/add_vulnerability_mappings branch April 19, 2023 22:43
agithomas pushed a commit to agithomas/integrations that referenced this pull request Apr 22, 2023
@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:cloud_security_posture Security Posture Management Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cloud Security] [CNVM] transform cuts off plenty of documents and views partial
5 participants