Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CNVM] Unify error handling UX #155449

Open
jeniawhite opened this issue Apr 20, 2023 · 5 comments
Open

[CNVM] Unify error handling UX #155449

jeniawhite opened this issue Apr 20, 2023 · 5 comments
Labels
Team:Cloud Security Cloud Security team related technical debt Improvement of the software architecture and operational architecture Vulnerability Management

Comments

@jeniawhite
Copy link
Contributor

jeniawhite commented Apr 20, 2023

Motivation

When handling unexpected errors the table disappears (examine screenshot)
The preferred way would be to show the table with its previous state and have a toaster notification about the error without affecting the current state when the server returns an error.

Origin issue (when mapping where missing)

Describe the bug

Not all of the fields in the findings table of vulnerability are mapped.
This PR should have solved this:

For some reason when I've had a system with pre-existing vulnerabilities, it wasn't handled (attempted to run a new transform).
This did not help and I would have expected my index to be updated.
I can also see the old mappings in the index.

Expected behavior
The table shouldn't crash when we sort any fields.

Screenshots
image

@jeniawhite jeniawhite added bug Fixes for quality problems that affect the customer experience Team:Cloud Security Cloud Security team related 8.8 candidate Vulnerability Management labels Apr 20, 2023
@kfirpeled kfirpeled assigned opauloh and unassigned kfirpeled Apr 20, 2023
@kfirpeled
Copy link
Contributor

@opauloh verified to me it doesn't happen after fixing the mappings
I'm lowering the priority of this issue to 2 as this is an edge case

@kfirpeled kfirpeled transferred this issue from elastic/cloudbeat Apr 20, 2023
@kfirpeled kfirpeled changed the title Vulnerability findings table crashes on sort of fields [Cloud Security] [Bug] [CNVM] Handle error when sorting on field without mapping defined Apr 20, 2023
@opauloh
Copy link
Contributor

opauloh commented Apr 21, 2023

Tested with @nick-alayil this doesn't happen anymore on new instance

@opauloh opauloh closed this as completed Apr 21, 2023
@kfirpeled kfirpeled changed the title [Cloud Security] [Bug] [CNVM] Handle error when sorting on field without mapping defined [Cloud Security] [Bug] [CNVM] Improve error handling Apr 23, 2023
@kfirpeled
Copy link
Contributor

Reopening the issue to improve our error handling

@kfirpeled kfirpeled reopened this Apr 23, 2023
@kfirpeled kfirpeled added 8.9 candidate and removed 8.8 candidate bug Fixes for quality problems that affect the customer experience labels Apr 23, 2023
@kfirpeled kfirpeled changed the title [Cloud Security] [Bug] [CNVM] Improve error handling [Cloud Security] [CNVM] Improve error handling Apr 23, 2023
@kfirpeled kfirpeled added the technical debt Improvement of the software architecture and operational architecture label May 2, 2023
@kfirpeled
Copy link
Contributor

Related to this issue, another tech debt from the past: #152944 (comment)
If you think it worth creating another issue for it and it is not relevant to this one, please do

@kfirpeled
Copy link
Contributor

could be related issue: #157954

@kfirpeled kfirpeled changed the title [Cloud Security] [CNVM] Improve error handling [Cloud Security] [CNVM] Improve error handling UX Jun 14, 2023
@kfirpeled kfirpeled changed the title [Cloud Security] [CNVM] Improve error handling UX [Cloud Security] [CNVM] Unify error handling UX Jun 14, 2023
@acorretti acorretti changed the title [Cloud Security] [CNVM] Unify error handling UX [CNVM] Unify error handling UX Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloud Security Cloud Security team related technical debt Improvement of the software architecture and operational architecture Vulnerability Management
Projects
None yet
Development

No branches or pull requests

4 participants