[ci] Enable Slack notifications on daily job status #6746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures
|
🌐 Coverage report
|
|
/test |
mrodm
reviewed
Jul 6, 2023
| @@ -59,7 +59,7 @@ pipeline { | |||
| } | |||
| post { | |||
| cleanup { | |||
| notifyBuildResult(prComment: false, slackHeader: "Integration job failed ${env.JENKINS_URL}search/?q=${env.INTEGRATION_JOB.replaceAll('/','+')}") | |||
| notifyBuildResult(prComment: false, slackComment: true, slackHeader: "Integration job failed ${env.JENKINS_URL}search/?q=${env.INTEGRATION_JOB.replaceAll('/','+')}") | |||
There was a problem hiding this comment.
There should not be needed to add this parameter, since SLACK_CHANNEL environment variable is defined here, according to the notifyBuildResult function
Could it be that the slack channel is missing some App?
There was a problem hiding this comment.
Dismiss the previous comment, re-checking the code, indeed, that parameter is needed.
mrodm
approved these changes
Jul 6, 2023
| @@ -59,7 +59,7 @@ pipeline { | |||
| } | |||
| post { | |||
| cleanup { | |||
| notifyBuildResult(prComment: false, slackHeader: "Integration job failed ${env.JENKINS_URL}search/?q=${env.INTEGRATION_JOB.replaceAll('/','+')}") | |||
| notifyBuildResult(prComment: false, slackComment: true, slackHeader: "Integration job failed ${env.JENKINS_URL}search/?q=${env.INTEGRATION_JOB.replaceAll('/','+')}") | |||
There was a problem hiding this comment.
Dismiss the previous comment, re-checking the code, indeed, that parameter is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As a minor improvement into the visibility of failures in the daily integration job, attempt to enable Slack notifications.
From digging into the pipeline library, the current config is missing
slackComment: truewhen notifying on the build status.Related issues
Relates to #6071.