Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Enable Slack notifications on daily job status #6746

Merged
merged 1 commit into from
Jul 6, 2023
Merged

[ci] Enable Slack notifications on daily job status #6746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/schedule-daily.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ pipeline {
}
post {
cleanup {
notifyBuildResult(prComment: false, slackHeader: "Integration job failed ${env.JENKINS_URL}search/?q=${env.INTEGRATION_JOB.replaceAll('/','+')}")
notifyBuildResult(prComment: false, slackComment: true, slackHeader: "Integration job failed ${env.JENKINS_URL}search/?q=${env.INTEGRATION_JOB.replaceAll('/','+')}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be needed to add this parameter, since SLACK_CHANNEL environment variable is defined here, according to the notifyBuildResult function

https://github.com/elastic/apm-pipeline-library/blob/a1c0d088ebeaac0741592d77e2fc60157557f854/vars/notifyBuildResult.groovy#L66

Could it be that the slack channel is missing some App?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismiss the previous comment, re-checking the code, indeed, that parameter is needed.

}
}
}