Skip to content

Commit

Permalink
[8.7] [Synthetics] fix local params in add monitor and edit monitor (#…
Browse files Browse the repository at this point in the history
…150602) (#150671)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Synthetics] fix local params in add monitor and edit monitor
(#150602)](#150602)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dominique
Clarke","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-09T10:07:26Z","message":"[Synthetics]
fix local params in add monitor and edit monitor (#150602)\n\nResolves
https://github.com/elastic/kibana/issues/150599\r\nResolves
https://github.com/elastic/kibana/issues/150597","sha":"876b3f5b3a537b87a0309c7d675003d2efae215a","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.7.0","v8.8.0"],"number":150602,"url":"https://github.com/elastic/kibana/pull/150602","mergeCommit":{"message":"[Synthetics]
fix local params in add monitor and edit monitor (#150602)\n\nResolves
https://github.com/elastic/kibana/issues/150599\r\nResolves
https://github.com/elastic/kibana/issues/150597","sha":"876b3f5b3a537b87a0309c7d675003d2efae215a"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150602","number":150602,"mergeCommit":{"message":"[Synthetics]
fix local params in add monitor and edit monitor (#150602)\n\nResolves
https://github.com/elastic/kibana/issues/150599\r\nResolves
https://github.com/elastic/kibana/issues/150597","sha":"876b3f5b3a537b87a0309c7d675003d2efae215a"}}]}]
BACKPORT-->

Co-authored-by: Dominique Clarke <[email protected]>
Co-authored-by: Shahzad <[email protected]>
  • Loading branch information
3 people authored Feb 10, 2023
1 parent 5fc3e02 commit 2917d1b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -890,8 +890,9 @@ export const FIELD = (readOnly?: boolean): FieldMap => ({
label: i18n.translate('xpack.synthetics.monitorConfig.params.label', {
defaultMessage: 'Parameters',
}),
controlled: true,
component: JSONEditor,
props: ({ setValue }): JSONCodeEditorProps => ({
props: (): JSONCodeEditorProps => ({
id: 'syntheticsMonitorConfigParams',
height: '100px',
ariaLabel: i18n.translate('xpack.synthetics.monitorConfig.paramsAria.label', {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ export const FORM_CONFIG = (readOnly: boolean): FieldConfig => ({
FIELD(readOnly)[AlertConfigKey.STATUS_ENABLED],
],
step3: [FIELD(readOnly)['source.inline'], FIELD(readOnly)[ConfigKey.PARAMS]],
scriptEdit: [FIELD(readOnly)['source.inline']],
scriptEdit: [FIELD(readOnly)['source.inline'], FIELD(readOnly)[ConfigKey.PARAMS]],
advanced: [
{
...DEFAULT_DATA_OPTIONS(readOnly),
Expand Down

0 comments on commit 2917d1b

Please sign in to comment.