Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] fix local params in add monitor and edit monitor #150602

Merged
merged 4 commits into from
Feb 9, 2023
Merged

[Synthetics] fix local params in add monitor and edit monitor #150602

merged 4 commits into from
Feb 9, 2023

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Feb 8, 2023 •
edited by kibanamachine
Loading

Summary

Resolves #150599
Resolves #150597

Allows specifying local params on the add monitor page.

Screen Shot 2023-02-08 at 11 43 38 AM

Screen Shot 2023-02-08 at 11 44 52 AM

Also enables editing params on the the edit monitor page.
Screen Shot 2023-02-08 at 11 46 09 AM

Testing

  1. Create a browser monitor that relies on a local param
  2. Ensure the monitor runs as expected with the local param
  3. Edit the monitor. Ensure the local params are visible in the edit monitor flow.

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.7.0 v8.8.0 labels Feb 8, 2023
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner February 8, 2023 16:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke dominiqueclarke changed the title synthetics - fix local params in add monitor and edit monitor [Synthetics] fix local params in add monitor and edit monitor Feb 8, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.4MB 1.4MB +21.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 876b3f5 into elastic:main Feb 9, 2023
@shahzad31 shahzad31 deleted the fix/synthetics-params-add-edit branch February 9, 2023 10:07
@kibanamachine kibanamachine mentioned this pull request Feb 9, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 9, 2023
@dominiqueclarke
[Synthetics] fix local params in add monitor and edit monitor (elasti…
19ddf09 
…c#150602)

Resolves elastic#150599
Resolves elastic#150597

(cherry picked from commit 876b3f5)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 10, 2023
@kibanamachine @dominiqueclarke @shahzad31
[8.7] [Synthetics] fix local params in add monitor and edit monitor (#…
2917d1b 
…150602) (#150671)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Synthetics] fix local params in add monitor and edit monitor
(#150602)](#150602)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dominique
Clarke","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-09T10:07:26Z","message":"[Synthetics]
fix local params in add monitor and edit monitor (#150602)\n\nResolves
https://github.com/elastic/kibana/issues/150599\r\nResolves
https://github.com/elastic/kibana/issues/150597","sha":"876b3f5b3a537b87a0309c7d675003d2efae215a","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.7.0","v8.8.0"],"number":150602,"url":"https://github.com/elastic/kibana/pull/150602","mergeCommit":{"message":"[Synthetics]
fix local params in add monitor and edit monitor (#150602)\n\nResolves
https://github.com/elastic/kibana/issues/150599\r\nResolves
https://github.com/elastic/kibana/issues/150597","sha":"876b3f5b3a537b87a0309c7d675003d2efae215a"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150602","number":150602,"mergeCommit":{"message":"[Synthetics]
fix local params in add monitor and edit monitor (#150602)\n\nResolves
https://github.com/elastic/kibana/issues/150599\r\nResolves
https://github.com/elastic/kibana/issues/150597","sha":"876b3f5b3a537b87a0309c7d675003d2efae215a"}}]}]
BACKPORT-->

Co-authored-by: Dominique Clarke <[email protected]>
Co-authored-by: Shahzad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.7.0 v8.8.0
Projects
None yet
Milestone
No milestone
5 participants
@dominiqueclarke @elasticmachine @kibana-ci @kibanamachine @shahzad31