Skip to content

Commit

Permalink
[8.x] Sustainable Kibana Architecture: Move modules owned by `@elasti…
Browse files Browse the repository at this point in the history
…c/kibana-localization` (#202725) (#203564)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Sustainable Kibana Architecture: Move modules owned by
`@elastic/kibana-localization`
(#202725)](#202725)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T12:56:15Z","message":"Sustainable
Kibana Architecture: Move modules owned by
`@elastic/kibana-localization` (#202725)\n\n## Summary\r\n\r\nThis PR
aims at relocating some of the Kibana modules (plugins and\r\npackages)
into a new folder structure, according to the _Sustainable\r\nKibana
Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you
to:\r\n> * Manually fix the errors in the error section below (if there
are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and
`plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint
config files), and update them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> This PR has been auto-generated.\r\n>
Do not attempt to push any changes unless you know what you are
doing.\r\n> Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\n\r\n\r\n\r\n#### 1 plugin(s) are going to
be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | -------------
|\r\n| `@kbn/translations-plugin`
|\r\n`x-pack/platform/plugins/private/translations`
|\r\n\r\n\r\n<details>\r\n<summary>Updated
references</summary>\r\n\r\n```\r\n./docs/developer/plugin-list.asciidoc\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-synthetic-package-map/synthetic-packages.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/dev/i18n_tools/README.md\r\n./tsconfig.base.json\r\n./tsconfig.refs.json\r\n./yarn.lock\r\n```\r\n</details>\r\n<details>\r\n<summary>Updated
relative
paths</summary>\r\n\r\n```\r\nx-pack/platform/plugins/private/translations/tsconfig.json:2\r\n```\r\n</details>\r\n<details>\r\n<summary>Script
errors</summary>\r\n\r\n```\r\n\r\n```\r\n</details>","sha":"c609daa97c2b0aa94aebc3fce76c9439e8a4d95c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:prev-minor"],"number":202725,"url":"https://github.com/elastic/kibana/pull/202725","mergeCommit":{"message":"Sustainable
Kibana Architecture: Move modules owned by
`@elastic/kibana-localization` (#202725)\n\n## Summary\r\n\r\nThis PR
aims at relocating some of the Kibana modules (plugins and\r\npackages)
into a new folder structure, according to the _Sustainable\r\nKibana
Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you
to:\r\n> * Manually fix the errors in the error section below (if there
are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and
`plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint
config files), and update them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> This PR has been auto-generated.\r\n>
Do not attempt to push any changes unless you know what you are
doing.\r\n> Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\n\r\n\r\n\r\n#### 1 plugin(s) are going to
be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | -------------
|\r\n| `@kbn/translations-plugin`
|\r\n`x-pack/platform/plugins/private/translations`
|\r\n\r\n\r\n<details>\r\n<summary>Updated
references</summary>\r\n\r\n```\r\n./docs/developer/plugin-list.asciidoc\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-synthetic-package-map/synthetic-packages.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/dev/i18n_tools/README.md\r\n./tsconfig.base.json\r\n./tsconfig.refs.json\r\n./yarn.lock\r\n```\r\n</details>\r\n<details>\r\n<summary>Updated
relative
paths</summary>\r\n\r\n```\r\nx-pack/platform/plugins/private/translations/tsconfig.json:2\r\n```\r\n</details>\r\n<details>\r\n<summary>Script
errors</summary>\r\n\r\n```\r\n\r\n```\r\n</details>","sha":"c609daa97c2b0aa94aebc3fce76c9439e8a4d95c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202725","number":202725,"mergeCommit":{"message":"Sustainable
Kibana Architecture: Move modules owned by
`@elastic/kibana-localization` (#202725)\n\n## Summary\r\n\r\nThis PR
aims at relocating some of the Kibana modules (plugins and\r\npackages)
into a new folder structure, according to the _Sustainable\r\nKibana
Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you
to:\r\n> * Manually fix the errors in the error section below (if there
are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and
`plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint
config files), and update them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> This PR has been auto-generated.\r\n>
Do not attempt to push any changes unless you know what you are
doing.\r\n> Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\n\r\n\r\n\r\n#### 1 plugin(s) are going to
be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | -------------
|\r\n| `@kbn/translations-plugin`
|\r\n`x-pack/platform/plugins/private/translations`
|\r\n\r\n\r\n<details>\r\n<summary>Updated
references</summary>\r\n\r\n```\r\n./docs/developer/plugin-list.asciidoc\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-synthetic-package-map/synthetic-packages.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/dev/i18n_tools/README.md\r\n./tsconfig.base.json\r\n./tsconfig.refs.json\r\n./yarn.lock\r\n```\r\n</details>\r\n<details>\r\n<summary>Updated
relative
paths</summary>\r\n\r\n```\r\nx-pack/platform/plugins/private/translations/tsconfig.json:2\r\n```\r\n</details>\r\n<details>\r\n<summary>Script
errors</summary>\r\n\r\n```\r\n\r\n```\r\n</details>","sha":"c609daa97c2b0aa94aebc3fce76c9439e8a4d95c"}}]}]
BACKPORT-->
  • Loading branch information
gsoldevila authored Dec 10, 2024
1 parent 467f7f1 commit a139ae9
Show file tree
Hide file tree
Showing 14 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -965,7 +965,7 @@ packages/kbn-timerange @elastic/obs-ux-logs-team
packages/kbn-tinymath @elastic/kibana-visualizations
packages/kbn-tooling-log @elastic/kibana-operations
x-pack/platform/plugins/private/transform @elastic/ml-ui
x-pack/plugins/translations @elastic/kibana-localization
x-pack/platform/plugins/private/translations @elastic/kibana-localization
packages/kbn-transpose-utils @elastic/kibana-visualizations
x-pack/examples/triggers_actions_ui_example @elastic/response-ops
x-pack/plugins/triggers_actions_ui @elastic/response-ops
Expand Down
2 changes: 1 addition & 1 deletion docs/developer/plugin-list.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -988,4 +988,4 @@ include::{kibana-root}/src/plugins/expressions/README.asciidoc[leveloffset=+1]
include::{kibana-root}/src/plugins/ui_actions/README.asciidoc[leveloffset=+1]
include::{kibana-root}/x-pack/plugins/dashboard_enhanced/README.asciidoc[leveloffset=+1]
include::{kibana-root}/x-pack/plugins/embeddable_enhanced/README.asciidoc[leveloffset=+1]
include::{kibana-root}/x-pack/plugins/translations/README.asciidoc[leveloffset=+1]
include::{kibana-root}/x-pack/platform/plugins/private/translations/README.asciidoc[leveloffset=+1]
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -961,7 +961,7 @@
"@kbn/timerange": "link:packages/kbn-timerange",
"@kbn/tinymath": "link:packages/kbn-tinymath",
"@kbn/transform-plugin": "link:x-pack/platform/plugins/private/transform",
"@kbn/translations-plugin": "link:x-pack/plugins/translations",
"@kbn/translations-plugin": "link:x-pack/platform/plugins/private/translations",
"@kbn/transpose-utils": "link:packages/kbn-transpose-utils",
"@kbn/triggers-actions-ui-example-plugin": "link:x-pack/examples/triggers_actions_ui_example",
"@kbn/triggers-actions-ui-plugin": "link:x-pack/plugins/triggers_actions_ui",
Expand Down
2 changes: 1 addition & 1 deletion src/dev/i18n_tools/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ The tool throws an exception if `formats` object is missing in locale file.
### Usage

```bash
node scripts/i18n_integrate --source path/to/locale.json --target x-pack/plugins/translations/translations/locale.json
node scripts/i18n_integrate --source path/to/locale.json --target x-pack/platform/plugins/private/translations/translations/locale.json
```

* `--source` path to the JSON file with translations that should be integrated.
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -1924,8 +1924,8 @@
"@kbn/tooling-log/*": ["packages/kbn-tooling-log/*"],
"@kbn/transform-plugin": ["x-pack/platform/plugins/private/transform"],
"@kbn/transform-plugin/*": ["x-pack/platform/plugins/private/transform/*"],
"@kbn/translations-plugin": ["x-pack/plugins/translations"],
"@kbn/translations-plugin/*": ["x-pack/plugins/translations/*"],
"@kbn/translations-plugin": ["x-pack/platform/plugins/private/translations"],
"@kbn/translations-plugin/*": ["x-pack/platform/plugins/private/translations/*"],
"@kbn/transpose-utils": ["packages/kbn-transpose-utils"],
"@kbn/transpose-utils/*": ["packages/kbn-transpose-utils/*"],
"@kbn/triggers-actions-ui-example-plugin": ["x-pack/examples/triggers_actions_ui_example"],
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../../../tsconfig.base.json",
"extends": "../../../../../tsconfig.base.json",
"compilerOptions": {
"outDir": "target/types",
},
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7655,7 +7655,7 @@
version "0.0.0"
uid ""

"@kbn/translations-plugin@link:x-pack/plugins/translations":
"@kbn/translations-plugin@link:x-pack/platform/plugins/private/translations":
version "0.0.0"
uid ""

Expand Down

0 comments on commit a139ae9

Please sign in to comment.