Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-localization
#202725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
gsoldevila
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
gsoldevila
added
backport:skip
gsoldevila
force-pushed
the
kbn-team-1309-move-kibana-localization
branch
2 times, most recently
from
0d9c0eb to
d6258dd
Compare
gsoldevila
added
backport:prev-minor
gsoldevila
force-pushed
the
kbn-team-1309-move-kibana-localization
branch
from
d6258dd to
01c834f
Compare
Bamieh
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
LGTM i dont think you missed anything. Our internal tooling inside kibana uses the references and they’re updated so we’re all good.
// x-pack/.i18nrc.json
"translations": [
"@kbn/translations-plugin/translations/zh-CN.json",
"@kbn/translations-plugin/translations/ja-JP.json",
"@kbn/translations-plugin/translations/fr-FR.json"
]
gsoldevila
force-pushed
the
kbn-team-1309-move-kibana-localization
branch
from
01c834f to
c14bbd2
Compare
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12256566348 |
💚 Build Succeeded
Metrics [docs]
History
|
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
gsoldevila
added a commit
to gsoldevila/kibana
that referenced
this pull request
Dec 10, 2024
…na-localization` (elastic#202725) ## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > This PR has been auto-generated. > Do not attempt to push any changes unless you know what you are doing. > Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. #### 1 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/translations-plugin` | `x-pack/platform/plugins/private/translations` | <details> <summary>Updated references</summary> ``` ./docs/developer/plugin-list.asciidoc ./package.json ./packages/kbn-repo-packages/package-map.json ./packages/kbn-synthetic-package-map/synthetic-packages.json ./packages/kbn-ts-projects/config-paths.json ./src/dev/i18n_tools/README.md ./tsconfig.base.json ./tsconfig.refs.json ./yarn.lock ``` </details> <details> <summary>Updated relative paths</summary> ``` x-pack/platform/plugins/private/translations/tsconfig.json:2 ``` </details> <details> <summary>Script errors</summary> ``` ``` </details> (cherry picked from commit c609daa) # Conflicts: # .github/CODEOWNERS
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
gsoldevila
added a commit
that referenced
this pull request
Dec 10, 2024
…c/kibana-localization` (#202725) (#203564) # Backport This will backport the following commits from `main` to `8.x`: - [Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-localization` (#202725)](#202725) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T12:56:15Z","message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-localization` (#202725)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> This PR has been auto-generated.\r\n> Do not attempt to push any changes unless you know what you are doing.\r\n> Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\n\r\n\r\n\r\n#### 1 plugin(s) are going to be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n| `@kbn/translations-plugin` |\r\n`x-pack/platform/plugins/private/translations` |\r\n\r\n\r\n<details>\r\n<summary>Updated references</summary>\r\n\r\n```\r\n./docs/developer/plugin-list.asciidoc\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-synthetic-package-map/synthetic-packages.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/dev/i18n_tools/README.md\r\n./tsconfig.base.json\r\n./tsconfig.refs.json\r\n./yarn.lock\r\n```\r\n</details>\r\n<details>\r\n<summary>Updated relative paths</summary>\r\n\r\n```\r\nx-pack/platform/plugins/private/translations/tsconfig.json:2\r\n```\r\n</details>\r\n<details>\r\n<summary>Script errors</summary>\r\n\r\n```\r\n\r\n```\r\n</details>","sha":"c609daa97c2b0aa94aebc3fce76c9439e8a4d95c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:prev-minor"],"number":202725,"url":"https://github.com/elastic/kibana/pull/202725","mergeCommit":{"message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-localization` (#202725)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> This PR has been auto-generated.\r\n> Do not attempt to push any changes unless you know what you are doing.\r\n> Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\n\r\n\r\n\r\n#### 1 plugin(s) are going to be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n| `@kbn/translations-plugin` |\r\n`x-pack/platform/plugins/private/translations` |\r\n\r\n\r\n<details>\r\n<summary>Updated references</summary>\r\n\r\n```\r\n./docs/developer/plugin-list.asciidoc\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-synthetic-package-map/synthetic-packages.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/dev/i18n_tools/README.md\r\n./tsconfig.base.json\r\n./tsconfig.refs.json\r\n./yarn.lock\r\n```\r\n</details>\r\n<details>\r\n<summary>Updated relative paths</summary>\r\n\r\n```\r\nx-pack/platform/plugins/private/translations/tsconfig.json:2\r\n```\r\n</details>\r\n<details>\r\n<summary>Script errors</summary>\r\n\r\n```\r\n\r\n```\r\n</details>","sha":"c609daa97c2b0aa94aebc3fce76c9439e8a4d95c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202725","number":202725,"mergeCommit":{"message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-localization` (#202725)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> This PR has been auto-generated.\r\n> Do not attempt to push any changes unless you know what you are doing.\r\n> Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\n\r\n\r\n\r\n#### 1 plugin(s) are going to be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n| `@kbn/translations-plugin` |\r\n`x-pack/platform/plugins/private/translations` |\r\n\r\n\r\n<details>\r\n<summary>Updated references</summary>\r\n\r\n```\r\n./docs/developer/plugin-list.asciidoc\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-synthetic-package-map/synthetic-packages.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/dev/i18n_tools/README.md\r\n./tsconfig.base.json\r\n./tsconfig.refs.json\r\n./yarn.lock\r\n```\r\n</details>\r\n<details>\r\n<summary>Updated relative paths</summary>\r\n\r\n```\r\nx-pack/platform/plugins/private/translations/tsconfig.json:2\r\n```\r\n</details>\r\n<details>\r\n<summary>Script errors</summary>\r\n\r\n```\r\n\r\n```\r\n</details>","sha":"c609daa97c2b0aa94aebc3fce76c9439e8a4d95c"}}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…na-localization` (elastic#202725) ## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > This PR has been auto-generated. > Do not attempt to push any changes unless you know what you are doing. > Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. #### 1 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/translations-plugin` | `x-pack/platform/plugins/private/translations` | <details> <summary>Updated references</summary> ``` ./docs/developer/plugin-list.asciidoc ./package.json ./packages/kbn-repo-packages/package-map.json ./packages/kbn-synthetic-package-map/synthetic-packages.json ./packages/kbn-ts-projects/config-paths.json ./src/dev/i18n_tools/README.md ./tsconfig.base.json ./tsconfig.refs.json ./yarn.lock ``` </details> <details> <summary>Updated relative paths</summary> ``` x-pack/platform/plugins/private/translations/tsconfig.json:2 ``` </details> <details> <summary>Script errors</summary> ``` ``` </details>
rudolf
added
the
plugin groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.
Important
packages[\/\\]andplugins[\/\\]patterns in the source code (Babel and Eslint config files), and update them appropriately..buildkite/scripts/pipelines/pull_request/pipeline.tsto ensure that any CI pipeline customizations continue to be correctly applied after the changed path names.tsand.jsfiles listed in the sections below, as some of them contain relative paths that have been updated.Note
This PR has been auto-generated.
Do not attempt to push any changes unless you know what you are doing.
Please use #sustainable_kibana_architecture Slack channel for feedback.
1 plugin(s) are going to be relocated:
@kbn/translations-pluginx-pack/platform/plugins/private/translationsUpdated references
Updated relative paths
Script errors