Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Switch to SavedObjectClient.resolve #105810

Closed
timroes opened this issue Jul 15, 2021 · 2 comments · Fixed by #112983
Closed

[Discover] Switch to SavedObjectClient.resolve #105810

timroes opened this issue Jul 15, 2021 · 2 comments · Fixed by #112983
Assignees
@alexwizp @dimaanj
Labels
blocker Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.0.0

Comments

@timroes
Copy link
Contributor

timroes commented Jul 15, 2021

We need to switch over to SavedObjectClient.resolve instead of .get in the 8.0 release. This issue tracks work for the search saved object loading.

For more details see #100489
@timroes timroes added blocker Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 labels Jul 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes mentioned this issue Jul 15, 2021
Closed
@timroes timroes mentioned this issue Aug 2, 2021
Closed
19 tasks
@jportner
Copy link
Contributor

In case anyone is following this issue but not the linked meta-issue (#100489):

I published the Sharing Saved Objects developer guide, please take a look before proceeding with the implementation. And of course, please reach out if you run into any problems!

Note that there are a few more steps than just switching to use resolve(), there are some server side changes too, see the dev guide for more details. I think you only need to be concerned about Steps 2-4 but it would be good for someone on your team to verify 👍

@timroes timroes added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@alexwizp alexwizp mentioned this issue Sep 28, 2021
Merged
4 tasks
@alexwizp alexwizp self-assigned this Sep 28, 2021
@alexwizp alexwizp mentioned this issue Oct 13, 2021
Merged
alexwizp added a commit to alexwizp/kibana that referenced this issue Oct 13, 2021
@alexwizp
[Discover] Step 4- Removing SavedObject usage for savedSearch
b6371a1 
Closes: elastic#105810
alexwizp added a commit that referenced this issue Oct 15, 2021
@alexwizp @kibanamachine
[Discover] Step 4- Removing SavedObject usage for savedSearch (#114790)
aee7df9 
* [Discover] Step 4- Removing SavedObject usage for savedSearch

Closes: #105810

* fix apis

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

@dimaanj dimaanj

Labels
blocker Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Removing SavedObject usage for savedSearch alexwizp/kibana
5 participants
@timroes @jportner @elasticmachine @alexwizp @dimaanj