Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Step 4- Removing SavedObject usage for savedSearch #114790

Merged
merged 3 commits into from
Oct 15, 2021
Merged

[Discover] Step 4- Removing SavedObject usage for savedSearch #114790

merged 3 commits into from
Oct 15, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Oct 13, 2021 •
edited
Loading

Final part of: #105810

Summary

@alexwizp alexwizp requested a review from VladLasitsa October 13, 2021 12:52
@alexwizp alexwizp force-pushed the discover-saved-search branch from a976f8e to f5c4d4e Compare October 13, 2021 14:31
@alexwizp alexwizp requested review from kertal and flash1293 October 13, 2021 18:43
@alexwizp alexwizp self-assigned this Oct 13, 2021
@alexwizp alexwizp added v7.16.0 v8.0.0 Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 13, 2021
@alexwizp alexwizp marked this pull request as ready for review October 13, 2021 18:44
@alexwizp alexwizp requested review from a team as code owners October 13, 2021 18:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@flash1293
Copy link
Contributor

Do we want to wait for #114620 with this?

@alexwizp
Copy link
Contributor Author

Do we want to wait for #114620 with this?
No

@flash1293
Copy link
Contributor

Removing 7.16 label on this - should only go into 8.0

@flash1293 flash1293 removed the v7.16.0 label Oct 14, 2021
@alexwizp
Copy link
Contributor Author

alexwizp commented Oct 14, 2021 •
edited
Loading

Removing 7.16 label on this - should only go into 8.0
Oh.. yes.., did it out of habit

@alexwizp alexwizp added the backport:skip This commit does not require backporting label Oct 14, 2021
@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 399 397 -2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
discover 77 55 -22

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
discover 7 6 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 23.6KB 22.3KB -1.3KB
visualizations 38.9KB 38.8KB -102.0B
total -1.4KB
Unknown metric groups

API count

id before after diff
discover 103 81 -22

References to deprecated APIs

id before after diff
discover 1801 1794 -7
visualizations 102 100 -2
total -9

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

majagrubic
majagrubic reviewed Oct 15, 2021
View reviewed changes
src/plugins/discover/server/saved_objects/search.ts
@@ -12,7 +12,8 @@ import { searchMigrations } from './search_migrations';
export const searchSavedObjectType: SavedObjectsType = {
name: 'search',
hidden: false,
namespaceType: 'single',
namespaceType: 'multiple-isolated',
convertToMultiNamespaceTypeVersion: '8.0.0',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please read https://www.elastic.co/guide/en/kibana/master/sharing-saved-objects.html#sharing-saved-objects-step-4

majagrubic
majagrubic approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@majagrubic majagrubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome on Mac OSX, Discover seems to work ok.

stratoula
stratoula approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana VisEditors code changes LGTM!

@alexwizp alexwizp merged commit aee7df9 into elastic:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majagrubic majagrubic majagrubic approved these changes

@stratoula stratoula stratoula approved these changes

@VladLasitsa VladLasitsa Awaiting requested review from VladLasitsa

@kertal kertal Awaiting requested review from kertal

@flash1293 flash1293 Awaiting requested review from flash1293

Assignees

@alexwizp alexwizp

Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexwizp @elasticmachine @flash1293 @kibanamachine @majagrubic @stratoula