Annotation groups Listing Page Papercuts #198731
Assignees
Labels
papercut
Small "burr" in the product that we should fix.
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
Comments
timductive
added
papercut
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
paulinashakirova
added a commit
that referenced
this issue
Jan 10, 2025
## Summary This PR fixes [Annotation groups Listing Page Papercuts](#198731) and [Dashboard Listing Page Papercuts](#198728) issues. 1. Changed the name of the first column 2. Fixed edit icon being invisible while editing functionality is available. In the past the logic was different - hiding of icon was happening based on `isEditable(item)` property, and in the [[Managed content] readonly in library views](https://github.com/elastic/kibana/pull/176263/files#diff-e442682471f1021a9126ddcad7e00a0d334e57ac8db512c1c3268e14ecac0074L552) PR the logic was changed to depend on adding a key `{ edit: { enabled: false }` if there is a need to hide the Edit button. What happened is that the logic should be -> If you don't want to show the Edit icon, add `{ edit: { enabled: false }`, but in the current code, although there is no such key, the pencil stays invisible, because the `Boolean(tableItemsRowActions[item.id]?.edit?.enabled)` resolved to `false` when it is `undefined` (when the Edit functionality isn't disabled.) In this PR I propose an adjustment to this line of code. 3. Changed the View Details icon. 4. Show Reload page toast when a user changes preferred `savedObjects:perPage` in Advanced Settings. 5. Fix sorting algorithm that was sorting incorrectly if the preferred `savedObjects:perPage` was less than 10. <img width="237" alt="Screenshot 2025-01-09 at 13 44 39" src="https://github.com/user-attachments/assets/77a6fd45-8845-4b06-818c-0af0dc01ede9" /> <img width="243" alt="Screenshot 2025-01-09 at 13 43 30" src="https://github.com/user-attachments/assets/3d9e03da-94dd-4e31-b33a-eb81e71b69dd" />
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Jan 10, 2025
## Summary This PR fixes [Annotation groups Listing Page Papercuts](elastic#198731) and [Dashboard Listing Page Papercuts](elastic#198728) issues. 1. Changed the name of the first column 2. Fixed edit icon being invisible while editing functionality is available. In the past the logic was different - hiding of icon was happening based on `isEditable(item)` property, and in the [[Managed content] readonly in library views](https://github.com/elastic/kibana/pull/176263/files#diff-e442682471f1021a9126ddcad7e00a0d334e57ac8db512c1c3268e14ecac0074L552) PR the logic was changed to depend on adding a key `{ edit: { enabled: false }` if there is a need to hide the Edit button. What happened is that the logic should be -> If you don't want to show the Edit icon, add `{ edit: { enabled: false }`, but in the current code, although there is no such key, the pencil stays invisible, because the `Boolean(tableItemsRowActions[item.id]?.edit?.enabled)` resolved to `false` when it is `undefined` (when the Edit functionality isn't disabled.) In this PR I propose an adjustment to this line of code. 3. Changed the View Details icon. 4. Show Reload page toast when a user changes preferred `savedObjects:perPage` in Advanced Settings. 5. Fix sorting algorithm that was sorting incorrectly if the preferred `savedObjects:perPage` was less than 10. <img width="237" alt="Screenshot 2025-01-09 at 13 44 39" src="https://github.com/user-attachments/assets/77a6fd45-8845-4b06-818c-0af0dc01ede9" /> <img width="243" alt="Screenshot 2025-01-09 at 13 43 30" src="https://github.com/user-attachments/assets/3d9e03da-94dd-4e31-b33a-eb81e71b69dd" /> (cherry picked from commit 86e8a2f)
kibanamachine
added a commit
that referenced
this issue
Jan 10, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[VisLibrary] AnnotGroup listing page papercuts (#205914)](#205914) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paulina Shakirova","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-10T13:38:00Z","message":"[VisLibrary] AnnotGroup listing page papercuts (#205914)\n\n## Summary\nThis PR fixes [Annotation groups Listing Page\nPapercuts](#198731) and\n[Dashboard Listing Page\nPapercuts](#198728) issues.\n\n1. Changed the name of the first column\n2. Fixed edit icon being invisible while editing functionality is\navailable.\nIn the past the logic was different - hiding of icon was happening based\non `isEditable(item)` property, and in the [[Managed content] readonly\nin library\nviews](https://github.com/elastic/kibana/pull/176263/files#diff-e442682471f1021a9126ddcad7e00a0d334e57ac8db512c1c3268e14ecac0074L552)\nPR the logic was changed to depend on adding a key `{ edit: { enabled:\nfalse }` if there is a need to hide the Edit button. What happened is\nthat the logic should be -> If you don't want to show the Edit icon, add\n`{ edit: { enabled: false }`, but in the current code, although there is\nno such key, the pencil stays invisible, because the\n`Boolean(tableItemsRowActions[item.id]?.edit?.enabled)` resolved to\n`false` when it is `undefined` (when the Edit functionality isn't\ndisabled.) In this PR I propose an adjustment to this line of code.\n3. Changed the View Details icon.\n4. Show Reload page toast when a user changes preferred\n`savedObjects:perPage` in Advanced Settings.\n5. Fix sorting algorithm that was sorting incorrectly if the preferred\n`savedObjects:perPage` was less than 10.\n\n<img width=\"237\" alt=\"Screenshot 2025-01-09 at 13 44 39\"\nsrc=\"https://github.com/user-attachments/assets/77a6fd45-8845-4b06-818c-0af0dc01ede9\"\n/>\n\n<img width=\"243\" alt=\"Screenshot 2025-01-09 at 13 43 30\"\nsrc=\"https://github.com/user-attachments/assets/3d9e03da-94dd-4e31-b33a-eb81e71b69dd\"\n/>","sha":"86e8a2fceeb24c83f52d421c18600811ac028ef4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:SharedUX","backport:prev-minor","papercut"],"title":"[VisLibrary] AnnotGroup listing page papercuts","number":205914,"url":"https://github.com/elastic/kibana/pull/205914","mergeCommit":{"message":"[VisLibrary] AnnotGroup listing page papercuts (#205914)\n\n## Summary\nThis PR fixes [Annotation groups Listing Page\nPapercuts](#198731) and\n[Dashboard Listing Page\nPapercuts](#198728) issues.\n\n1. Changed the name of the first column\n2. Fixed edit icon being invisible while editing functionality is\navailable.\nIn the past the logic was different - hiding of icon was happening based\non `isEditable(item)` property, and in the [[Managed content] readonly\nin library\nviews](https://github.com/elastic/kibana/pull/176263/files#diff-e442682471f1021a9126ddcad7e00a0d334e57ac8db512c1c3268e14ecac0074L552)\nPR the logic was changed to depend on adding a key `{ edit: { enabled:\nfalse }` if there is a need to hide the Edit button. What happened is\nthat the logic should be -> If you don't want to show the Edit icon, add\n`{ edit: { enabled: false }`, but in the current code, although there is\nno such key, the pencil stays invisible, because the\n`Boolean(tableItemsRowActions[item.id]?.edit?.enabled)` resolved to\n`false` when it is `undefined` (when the Edit functionality isn't\ndisabled.) In this PR I propose an adjustment to this line of code.\n3. Changed the View Details icon.\n4. Show Reload page toast when a user changes preferred\n`savedObjects:perPage` in Advanced Settings.\n5. Fix sorting algorithm that was sorting incorrectly if the preferred\n`savedObjects:perPage` was less than 10.\n\n<img width=\"237\" alt=\"Screenshot 2025-01-09 at 13 44 39\"\nsrc=\"https://github.com/user-attachments/assets/77a6fd45-8845-4b06-818c-0af0dc01ede9\"\n/>\n\n<img width=\"243\" alt=\"Screenshot 2025-01-09 at 13 43 30\"\nsrc=\"https://github.com/user-attachments/assets/3d9e03da-94dd-4e31-b33a-eb81e71b69dd\"\n/>","sha":"86e8a2fceeb24c83f52d421c18600811ac028ef4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205914","number":205914,"mergeCommit":{"message":"[VisLibrary] AnnotGroup listing page papercuts (#205914)\n\n## Summary\nThis PR fixes [Annotation groups Listing Page\nPapercuts](#198731) and\n[Dashboard Listing Page\nPapercuts](#198728) issues.\n\n1. Changed the name of the first column\n2. Fixed edit icon being invisible while editing functionality is\navailable.\nIn the past the logic was different - hiding of icon was happening based\non `isEditable(item)` property, and in the [[Managed content] readonly\nin library\nviews](https://github.com/elastic/kibana/pull/176263/files#diff-e442682471f1021a9126ddcad7e00a0d334e57ac8db512c1c3268e14ecac0074L552)\nPR the logic was changed to depend on adding a key `{ edit: { enabled:\nfalse }` if there is a need to hide the Edit button. What happened is\nthat the logic should be -> If you don't want to show the Edit icon, add\n`{ edit: { enabled: false }`, but in the current code, although there is\nno such key, the pencil stays invisible, because the\n`Boolean(tableItemsRowActions[item.id]?.edit?.enabled)` resolved to\n`false` when it is `undefined` (when the Edit functionality isn't\ndisabled.) In this PR I propose an adjustment to this line of code.\n3. Changed the View Details icon.\n4. Show Reload page toast when a user changes preferred\n`savedObjects:perPage` in Advanced Settings.\n5. Fix sorting algorithm that was sorting incorrectly if the preferred\n`savedObjects:perPage` was less than 10.\n\n<img width=\"237\" alt=\"Screenshot 2025-01-09 at 13 44 39\"\nsrc=\"https://github.com/user-attachments/assets/77a6fd45-8845-4b06-818c-0af0dc01ede9\"\n/>\n\n<img width=\"243\" alt=\"Screenshot 2025-01-09 at 13 43 30\"\nsrc=\"https://github.com/user-attachments/assets/3d9e03da-94dd-4e31-b33a-eb81e71b69dd\"\n/>","sha":"86e8a2fceeb24c83f52d421c18600811ac028ef4"}}]}] BACKPORT--> Co-authored-by: Paulina Shakirova <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this issue
Jan 13, 2025
## Summary This PR fixes [Annotation groups Listing Page Papercuts](elastic#198731) and [Dashboard Listing Page Papercuts](elastic#198728) issues. 1. Changed the name of the first column 2. Fixed edit icon being invisible while editing functionality is available. In the past the logic was different - hiding of icon was happening based on `isEditable(item)` property, and in the [[Managed content] readonly in library views](https://github.com/elastic/kibana/pull/176263/files#diff-e442682471f1021a9126ddcad7e00a0d334e57ac8db512c1c3268e14ecac0074L552) PR the logic was changed to depend on adding a key `{ edit: { enabled: false }` if there is a need to hide the Edit button. What happened is that the logic should be -> If you don't want to show the Edit icon, add `{ edit: { enabled: false }`, but in the current code, although there is no such key, the pencil stays invisible, because the `Boolean(tableItemsRowActions[item.id]?.edit?.enabled)` resolved to `false` when it is `undefined` (when the Edit functionality isn't disabled.) In this PR I propose an adjustment to this line of code. 3. Changed the View Details icon. 4. Show Reload page toast when a user changes preferred `savedObjects:perPage` in Advanced Settings. 5. Fix sorting algorithm that was sorting incorrectly if the preferred `savedObjects:perPage` was less than 10. <img width="237" alt="Screenshot 2025-01-09 at 13 44 39" src="https://github.com/user-attachments/assets/77a6fd45-8845-4b06-818c-0af0dc01ede9" /> <img width="243" alt="Screenshot 2025-01-09 at 13 43 30" src="https://github.com/user-attachments/assets/3d9e03da-94dd-4e31-b33a-eb81e71b69dd" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is an "Action" column with no actions. Either add "Edit" and "Delete" or remove the column.
The text was updated successfully, but these errors were encountered: