Listing page papercuts part 1 #205914
Merged
Listing page papercuts part 1 #205914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulinashakirova
added
release_note:fix
Team:SharedUX
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Dosant
reviewed
Jan 9, 2025
...tform/packages/shared/content-management/table_list_view_table/src/table_list_view_table.tsx
Show resolved
Hide resolved
Dosant
reviewed
Jan 9, 2025
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
davismcphee
approved these changes
Jan 9, 2025
| @@ -23,6 +23,7 @@ export const uiSettings: Record<string, UiSettingsParams> = { | |||
| description: i18n.translate('savedObjectsFinder.advancedSettings.perPageText', { | |||
| defaultMessage: 'Number of objects to show per page in the load dialog', | |||
| }), | |||
| requiresPageReload: true, | |||
There was a problem hiding this comment.
Just curious because I didn't see it mentioned in the linked issues, but what prompted this change? Were SO tables not getting the updated value without a reload?
There was a problem hiding this comment.
Hi, @davismcphee! 👋🏻
Yes, this is what I found to be the case. 😊
I was working on the part that says "table paging should respect savedObjects:perPage advanced setting." in the parent Meta issue, and that point made me research why this was even the question. And those 2 things I found - fixed the issue.
Dosant
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
code lgtm.
This is a different issue for potentially another PR, but I noticed it because of a fixed edit icon that is now visible. I think this gap that is coming from EUI is a bit too large:
I wonder if we should override and remove it:
@ek-so wdyt?
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12710599148 |
paulinashakirova
changed the title
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 10, 2025
## Summary This PR fixes [Annotation groups Listing Page Papercuts](elastic#198731) and [Dashboard Listing Page Papercuts](elastic#198728) issues. 1. Changed the name of the first column 2. Fixed edit icon being invisible while editing functionality is available. In the past the logic was different - hiding of icon was happening based on `isEditable(item)` property, and in the [[Managed content] readonly in library views](https://github.com/elastic/kibana/pull/176263/files#diff-e442682471f1021a9126ddcad7e00a0d334e57ac8db512c1c3268e14ecac0074L552) PR the logic was changed to depend on adding a key `{ edit: { enabled: false }` if there is a need to hide the Edit button. What happened is that the logic should be -> If you don't want to show the Edit icon, add `{ edit: { enabled: false }`, but in the current code, although there is no such key, the pencil stays invisible, because the `Boolean(tableItemsRowActions[item.id]?.edit?.enabled)` resolved to `false` when it is `undefined` (when the Edit functionality isn't disabled.) In this PR I propose an adjustment to this line of code. 3. Changed the View Details icon. 4. Show Reload page toast when a user changes preferred `savedObjects:perPage` in Advanced Settings. 5. Fix sorting algorithm that was sorting incorrectly if the preferred `savedObjects:perPage` was less than 10. <img width="237" alt="Screenshot 2025-01-09 at 13 44 39" src="https://github.com/user-attachments/assets/77a6fd45-8845-4b06-818c-0af0dc01ede9" /> <img width="243" alt="Screenshot 2025-01-09 at 13 43 30" src="https://github.com/user-attachments/assets/3d9e03da-94dd-4e31-b33a-eb81e71b69dd" /> (cherry picked from commit 86e8a2f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 10, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[VisLibrary] AnnotGroup listing page papercuts (#205914)](#205914) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paulina Shakirova","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-10T13:38:00Z","message":"[VisLibrary] AnnotGroup listing page papercuts (#205914)\n\n## Summary\nThis PR fixes [Annotation groups Listing Page\nPapercuts](#198731) and\n[Dashboard Listing Page\nPapercuts](#198728) issues.\n\n1. Changed the name of the first column\n2. Fixed edit icon being invisible while editing functionality is\navailable.\nIn the past the logic was different - hiding of icon was happening based\non `isEditable(item)` property, and in the [[Managed content] readonly\nin library\nviews](https://github.com/elastic/kibana/pull/176263/files#diff-e442682471f1021a9126ddcad7e00a0d334e57ac8db512c1c3268e14ecac0074L552)\nPR the logic was changed to depend on adding a key `{ edit: { enabled:\nfalse }` if there is a need to hide the Edit button. What happened is\nthat the logic should be -> If you don't want to show the Edit icon, add\n`{ edit: { enabled: false }`, but in the current code, although there is\nno such key, the pencil stays invisible, because the\n`Boolean(tableItemsRowActions[item.id]?.edit?.enabled)` resolved to\n`false` when it is `undefined` (when the Edit functionality isn't\ndisabled.) In this PR I propose an adjustment to this line of code.\n3. Changed the View Details icon.\n4. Show Reload page toast when a user changes preferred\n`savedObjects:perPage` in Advanced Settings.\n5. Fix sorting algorithm that was sorting incorrectly if the preferred\n`savedObjects:perPage` was less than 10.\n\n<img width=\"237\" alt=\"Screenshot 2025-01-09 at 13 44 39\"\nsrc=\"https://github.com/user-attachments/assets/77a6fd45-8845-4b06-818c-0af0dc01ede9\"\n/>\n\n<img width=\"243\" alt=\"Screenshot 2025-01-09 at 13 43 30\"\nsrc=\"https://github.com/user-attachments/assets/3d9e03da-94dd-4e31-b33a-eb81e71b69dd\"\n/>","sha":"86e8a2fceeb24c83f52d421c18600811ac028ef4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:SharedUX","backport:prev-minor","papercut"],"title":"[VisLibrary] AnnotGroup listing page papercuts","number":205914,"url":"https://github.com/elastic/kibana/pull/205914","mergeCommit":{"message":"[VisLibrary] AnnotGroup listing page papercuts (#205914)\n\n## Summary\nThis PR fixes [Annotation groups Listing Page\nPapercuts](#198731) and\n[Dashboard Listing Page\nPapercuts](#198728) issues.\n\n1. Changed the name of the first column\n2. Fixed edit icon being invisible while editing functionality is\navailable.\nIn the past the logic was different - hiding of icon was happening based\non `isEditable(item)` property, and in the [[Managed content] readonly\nin library\nviews](https://github.com/elastic/kibana/pull/176263/files#diff-e442682471f1021a9126ddcad7e00a0d334e57ac8db512c1c3268e14ecac0074L552)\nPR the logic was changed to depend on adding a key `{ edit: { enabled:\nfalse }` if there is a need to hide the Edit button. What happened is\nthat the logic should be -> If you don't want to show the Edit icon, add\n`{ edit: { enabled: false }`, but in the current code, although there is\nno such key, the pencil stays invisible, because the\n`Boolean(tableItemsRowActions[item.id]?.edit?.enabled)` resolved to\n`false` when it is `undefined` (when the Edit functionality isn't\ndisabled.) In this PR I propose an adjustment to this line of code.\n3. Changed the View Details icon.\n4. Show Reload page toast when a user changes preferred\n`savedObjects:perPage` in Advanced Settings.\n5. Fix sorting algorithm that was sorting incorrectly if the preferred\n`savedObjects:perPage` was less than 10.\n\n<img width=\"237\" alt=\"Screenshot 2025-01-09 at 13 44 39\"\nsrc=\"https://github.com/user-attachments/assets/77a6fd45-8845-4b06-818c-0af0dc01ede9\"\n/>\n\n<img width=\"243\" alt=\"Screenshot 2025-01-09 at 13 43 30\"\nsrc=\"https://github.com/user-attachments/assets/3d9e03da-94dd-4e31-b33a-eb81e71b69dd\"\n/>","sha":"86e8a2fceeb24c83f52d421c18600811ac028ef4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205914","number":205914,"mergeCommit":{"message":"[VisLibrary] AnnotGroup listing page papercuts (#205914)\n\n## Summary\nThis PR fixes [Annotation groups Listing Page\nPapercuts](#198731) and\n[Dashboard Listing Page\nPapercuts](#198728) issues.\n\n1. Changed the name of the first column\n2. Fixed edit icon being invisible while editing functionality is\navailable.\nIn the past the logic was different - hiding of icon was happening based\non `isEditable(item)` property, and in the [[Managed content] readonly\nin library\nviews](https://github.com/elastic/kibana/pull/176263/files#diff-e442682471f1021a9126ddcad7e00a0d334e57ac8db512c1c3268e14ecac0074L552)\nPR the logic was changed to depend on adding a key `{ edit: { enabled:\nfalse }` if there is a need to hide the Edit button. What happened is\nthat the logic should be -> If you don't want to show the Edit icon, add\n`{ edit: { enabled: false }`, but in the current code, although there is\nno such key, the pencil stays invisible, because the\n`Boolean(tableItemsRowActions[item.id]?.edit?.enabled)` resolved to\n`false` when it is `undefined` (when the Edit functionality isn't\ndisabled.) In this PR I propose an adjustment to this line of code.\n3. Changed the View Details icon.\n4. Show Reload page toast when a user changes preferred\n`savedObjects:perPage` in Advanced Settings.\n5. Fix sorting algorithm that was sorting incorrectly if the preferred\n`savedObjects:perPage` was less than 10.\n\n<img width=\"237\" alt=\"Screenshot 2025-01-09 at 13 44 39\"\nsrc=\"https://github.com/user-attachments/assets/77a6fd45-8845-4b06-818c-0af0dc01ede9\"\n/>\n\n<img width=\"243\" alt=\"Screenshot 2025-01-09 at 13 43 30\"\nsrc=\"https://github.com/user-attachments/assets/3d9e03da-94dd-4e31-b33a-eb81e71b69dd\"\n/>","sha":"86e8a2fceeb24c83f52d421c18600811ac028ef4"}}]}] BACKPORT--> Co-authored-by: Paulina Shakirova <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
## Summary This PR fixes [Annotation groups Listing Page Papercuts](elastic#198731) and [Dashboard Listing Page Papercuts](elastic#198728) issues. 1. Changed the name of the first column 2. Fixed edit icon being invisible while editing functionality is available. In the past the logic was different - hiding of icon was happening based on `isEditable(item)` property, and in the [[Managed content] readonly in library views](https://github.com/elastic/kibana/pull/176263/files#diff-e442682471f1021a9126ddcad7e00a0d334e57ac8db512c1c3268e14ecac0074L552) PR the logic was changed to depend on adding a key `{ edit: { enabled: false }` if there is a need to hide the Edit button. What happened is that the logic should be -> If you don't want to show the Edit icon, add `{ edit: { enabled: false }`, but in the current code, although there is no such key, the pencil stays invisible, because the `Boolean(tableItemsRowActions[item.id]?.edit?.enabled)` resolved to `false` when it is `undefined` (when the Edit functionality isn't disabled.) In this PR I propose an adjustment to this line of code. 3. Changed the View Details icon. 4. Show Reload page toast when a user changes preferred `savedObjects:perPage` in Advanced Settings. 5. Fix sorting algorithm that was sorting incorrectly if the preferred `savedObjects:perPage` was less than 10. <img width="237" alt="Screenshot 2025-01-09 at 13 44 39" src="https://github.com/user-attachments/assets/77a6fd45-8845-4b06-818c-0af0dc01ede9" /> <img width="243" alt="Screenshot 2025-01-09 at 13 43 30" src="https://github.com/user-attachments/assets/3d9e03da-94dd-4e31-b33a-eb81e71b69dd" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Annotation groups Listing Page Papercuts and Dashboard Listing Page Papercuts issues.
In the past the logic was different - hiding of icon was happening based on
isEditable(item)property, and in the [Managed content] readonly in library views PR the logic was changed to depend on adding a key{ edit: { enabled: false }if there is a need to hide the Edit button. What happened is that the logic should be -> If you don't want to show the Edit icon, add{ edit: { enabled: false }, but in the current code, although there is no such key, the pencil stays invisible, because theBoolean(tableItemsRowActions[item.id]?.edit?.enabled)resolved tofalsewhen it isundefined(when the Edit functionality isn't disabled.) In this PR I propose an adjustment to this line of code.savedObjects:perPagein Advanced Settings.savedObjects:perPagewas less than 10.