Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Link to Fleet APM Server Configuration when managed by Elastic Agent w/Fleet #100816

Merged
merged 37 commits into from
Jun 24, 2021
Merged

[APM] Link to Fleet APM Server Configuration when managed by Elastic Agent w/Fleet #100816

merged 37 commits into from
Jun 24, 2021

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented May 27, 2021 •
edited
Loading

closes #88659

With APM integration
Screen Shot 2021-06-01 at 10 05 44
Screen Shot 2021-06-01 at 10 06 16

Without APM integration
Screen Shot 2021-06-01 at 10 07 41
Screen Shot 2021-06-01 at 10 08 02

closes #100962

Screen Shot 2021-05-31 at 16 28 03

closes #100672

ezgif com-gif-maker(1)

@cauemarcondes cauemarcondes added apm:fleet release_note:enhancement v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels May 31, 2021
@cauemarcondes cauemarcondes marked this pull request as ready for review June 1, 2021 15:22
@cauemarcondes cauemarcondes requested review from a team as code owners June 1, 2021 15:22
@cauemarcondes
Copy link
Contributor Author

jenkins, retest this please

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jun 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes requested a review from sorenlouv June 1, 2021 20:26
pgayvallet
pgayvallet reviewed Jun 2, 2021
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instructions being registered on the server-side, I don't think we can avoid having this APMFleet component living inside home without major changes, so I guess this is the only pragmatic solution.

However having an implicit dependency between home and apm by having a components inside home querying apm endpoints directly is just... wrong. I would really try to find a solution to avoid that.

src/plugins/home/public/application/components/apm_fleet/index.tsx Outdated Show resolved Hide resolved
src/plugins/home/public/application/components/tutorial/instruction.js Outdated Show resolved Hide resolved
src/plugins/home/public/application/components/tutorial/tutorial.js Outdated Show resolved Hide resolved
x-pack/plugins/apm/server/tutorial/envs/on_prem.ts Outdated Show resolved Hide resolved
@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

ogupte
ogupte approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left just one comment on making fleet a required plugin dependency.

@cauemarcondes
Copy link
Contributor Author

jenkins, retest this please

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1535 1537 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
home 65 70 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB +4.8KB
home 164.4KB 165.9KB +1.5KB
total +6.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 37.4KB 38.4KB +952.0B
home 15.4KB 16.1KB +726.0B
total +1.6KB
Unknown metric groups

API count

id before after diff
home 89 94 +5

async chunk count

id before after diff
apm 11 13 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit f293772 into elastic:master Jun 24, 2021
@cauemarcondes cauemarcondes deleted the apm-fleet-tutorial branch June 24, 2021 14:53
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 24, 2021
@cauemarcondes @kibanamachine
[APM] Link to Fleet APM Server Configuration when managed by Elastic …
c6be69a 
…Agent w/Fleet (elastic#100816)

* Register tutorial on APM plugin

* using files from apm

* removing tutorial from apm_oss

* removing export

* fixing i18n

* adding fleet section

* adding fleet information on APM tutorial

* adding fleet typing

* fixing i18n

* adding fleet information on APM tutorial

* checks apm fleet integration when pushing button

* adding fleet information on APM tutorial

* refactoring

* registering status check callback

* addin custom component registration function

* fixing TS issue

* addressing PR comments

* fixing tests

* adding i18n

* fixing issues

* adding unit test

* adding unit test

* addressing PR comments

* fixing TS issue

* moving tutorial to a common directory

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Jun 24, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 24, 2021
@kibanamachine @cauemarcondes
[APM] Link to Fleet APM Server Configuration when managed by Elastic …
669839c 
…Agent w/Fleet (#100816) (#103302)

* Register tutorial on APM plugin

* using files from apm

* removing tutorial from apm_oss

* removing export

* fixing i18n

* adding fleet section

* adding fleet information on APM tutorial

* adding fleet typing

* fixing i18n

* adding fleet information on APM tutorial

* checks apm fleet integration when pushing button

* adding fleet information on APM tutorial

* refactoring

* registering status check callback

* addin custom component registration function

* fixing TS issue

* addressing PR comments

* fixing tests

* adding i18n

* fixing issues

* adding unit test

* adding unit test

* addressing PR comments

* fixing TS issue

* moving tutorial to a common directory

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Cauê Marcondes <[email protected]>
@sorenlouv sorenlouv mentioned this pull request Aug 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@formgeist formgeist formgeist left review comments

@ogupte ogupte ogupte approved these changes

@joshdover joshdover joshdover approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
apm:fleet auto-backport Deprecated - use backport:version if exact versions are needed release_note:enhancement Team:APM All issues that need APM UI Team support v7.14.0
Projects
None yet
Milestone
No milestone
8 participants
@cauemarcondes @elasticmachine @kibanamachine @sorenlouv @pgayvallet @joshdover @ogupte @formgeist