Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Fix background styling of waterfall chart sidebar tooltip #103997

Merged
merged 4 commits into from
Jul 7, 2021
Merged

[Synthetics] Fix background styling of waterfall chart sidebar tooltip #103997

merged 4 commits into from
Jul 7, 2021

Conversation

justinkambic
Copy link
Contributor

Summary

Resolves #103090.

The style on one of the waterfall chart tooltips was not being set. This patch will make both tooltips use the same style.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability polish v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 30, 2021
@justinkambic justinkambic requested a review from a team as a code owner June 30, 2021 20:28
@justinkambic justinkambic self-assigned this Jun 30, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@justinkambic justinkambic added the release_note:skip Skip the PR/issue when compiling release notes label Jun 30, 2021
@justinkambic justinkambic enabled auto-merge (squash) June 30, 2021 20:29
@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

@spalger spalger added the v7.15.0 label Jul 7, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 955.3KB 955.3KB -13.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

dominiqueclarke
dominiqueclarke approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Styles are as expected.

@justinkambic justinkambic merged commit 8daffb0 into elastic:master Jul 7, 2021
@kibanamachine kibanamachine mentioned this pull request Jul 7, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 7, 2021
@justinkambic @kibanamachine
Fix background styling of waterfall chart sidebar tooltip. (elastic#1…
be6037b 
…03997)
@kibanamachine kibanamachine mentioned this pull request Jul 7, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 7, 2021
@justinkambic @kibanamachine
Fix background styling of waterfall chart sidebar tooltip. (elastic#1…
0aeb180 
…03997)
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 7, 2021
@kibanamachine @justinkambic
Fix background styling of waterfall chart sidebar tooltip. (#103997) (#…
e8a9572 
…104740)

Co-authored-by: Justin Kambic <[email protected]>
kibanamachine added a commit that referenced this pull request Jul 7, 2021
@kibanamachine @justinkambic
Fix background styling of waterfall chart sidebar tooltip. (#103997) (#…
90449e7 
…104739)

Co-authored-by: Justin Kambic <[email protected]>
@justinkambic justinkambic deleted the 103090/fix-waterfall-chart-tooltip-styling branch July 7, 2021 20:52
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 8, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into fleet/fix-use…
8a8729b 
…-of-max-results

* 'master' of github.com:elastic/kibana: (36 commits)
  Lower Kibana app bundle limits (elastic#104688)
  [Security Solutions] Fixes bug with the filter query compatibility for transforms (elastic#104559)
  [RAC] Add mapping update logic to RuleDataClient (elastic#102586)
  Fix import workpad (elastic#104722)
  [canvas] Fix Storybook service decorator (elastic#104750)
  [Detection Rules] Add 7.14 rules (elastic#104772)
  [Enterprise Search] Fix beta notification in sidebar (elastic#104763)
  Fix engine routes that are meta engine or non-meta-engine specific (elastic#104757)
  [Fleet] Fix policy revision number getting bumped for no reason (elastic#104696)
  persistable state migrations (elastic#103680)
  [Fleet] Fix add agent in the package policy table (elastic#104749)
  [DOCS] Creates separate doc for security in production (elastic#103973)
  [SO Migration] fix reindex race on multi-instance mode (elastic#104516)
  [Security Solution] Update text in Endpoint Admin pages (elastic#104649)
  [package testing] Decrease timeout to 2 hours (elastic#104668)
  Fix background styling of waterfall chart sidebar tooltip. (elastic#103997)
  [Fleet + Integrations UI] Integrations UI Cleanup (elastic#104641)
  [Fleet] Link to download page of current stack version on Agent install instructions (elastic#104494)
  [Workplace Search] Fix Media Type field preview is unformatted bug (elastic#104684)
  [ML] add marker body (elastic#104672)
  ...

# Conflicts:
#	x-pack/plugins/fleet/public/search_provider.test.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees

@justinkambic justinkambic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience polish release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Synthetics] Waterfall chart tooltip backgrounds do not match
5 participants
@justinkambic @elasticmachine @kibanamachine @dominiqueclarke @spalger