[Fleet] Link to download page of current stack version on Agent install instructions #104494
Conversation
Zacqary
added
release_note:fix
v8.0.0
Feature:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
|
Pinging @elastic/fleet (Feature:Fleet) |
x-pack/plugins/fleet/public/components/agent_enrollment_flyout/steps.tsx
Outdated
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @Zacqary |
| <EuiSpacer size="l" /> | ||
| <EuiButton | ||
| href="https://ela.st/download-elastic-agent" | ||
| href={`https://www.elastic.co/downloads/past-releases/elastic-agent-${kibanaVersionURLString}`} |
There was a problem hiding this comment.
one thing that will be annoying, is that this link will be broken for releases which are not published yet (i.e. local development from master/8.0.0, build candidates like the upcoming 7.14.0)
but I'm not sure what we can do about that. @mostlyjason WDYT?
There was a problem hiding this comment.
I was concerned about that too, but there doesn't seem to be an easy way to determine in the code whether or not a version is released yet. This might just have to be a thing we deal with in development.
Zacqary
added
the
auto-backport
|
LGTM. Minor thing: there is only one installer for Linux so it can be singular |
| import { FLEET_SERVER_PACKAGE } from '../../constants'; | ||
|
|
||
| import { EnrollmentStepAgentPolicy } from './agent_policy_selection'; | ||
| import { AdvancedAgentAuthenticationSettings } from './advanced_agent_authentication_settings'; | ||
|
|
||
| export const DownloadStep = () => { | ||
| const kibanaVersion = useKibanaVersion(); | ||
| const kibanaVersionURLString = useMemo( |
There was a problem hiding this comment.
It's not a blocker for me, but in the main branch this will go to https://www.elastic.co/downloads/past-releases/elastic-agent-8-0-0 which 404's.
I don't know if it's better to leave the existing https://ela.st/download-elastic-agent for snapshot builds or use this invalid URL
One optional enhancement for another time/PR is to use the results from https://artifacts-api.elastic.co/v1/search/8.0-SNAPSHOT/elastic-agent to make a list of links like below (in the flyout?)
None of these are requirements to ship, IMO; just pointing out what I noticed
…ll instructions (elastic#104494) * [Fleet] Link to download page of current stack version * Get Kibana version from semver function * Fix jest
…ll instructions (elastic#104494) * [Fleet] Link to download page of current stack version * Get Kibana version from semver function * Fix jest
…ll instructions (#104494) (#104730) * [Fleet] Link to download page of current stack version * Get Kibana version from semver function * Fix jest Co-authored-by: Zacqary Adam Xeper <[email protected]>
…ll instructions (#104494) (#104731) * [Fleet] Link to download page of current stack version * Get Kibana version from semver function * Fix jest Co-authored-by: Zacqary Adam Xeper <[email protected]>
…-of-max-results * 'master' of github.com:elastic/kibana: (36 commits) Lower Kibana app bundle limits (elastic#104688) [Security Solutions] Fixes bug with the filter query compatibility for transforms (elastic#104559) [RAC] Add mapping update logic to RuleDataClient (elastic#102586) Fix import workpad (elastic#104722) [canvas] Fix Storybook service decorator (elastic#104750) [Detection Rules] Add 7.14 rules (elastic#104772) [Enterprise Search] Fix beta notification in sidebar (elastic#104763) Fix engine routes that are meta engine or non-meta-engine specific (elastic#104757) [Fleet] Fix policy revision number getting bumped for no reason (elastic#104696) persistable state migrations (elastic#103680) [Fleet] Fix add agent in the package policy table (elastic#104749) [DOCS] Creates separate doc for security in production (elastic#103973) [SO Migration] fix reindex race on multi-instance mode (elastic#104516) [Security Solution] Update text in Endpoint Admin pages (elastic#104649) [package testing] Decrease timeout to 2 hours (elastic#104668) Fix background styling of waterfall chart sidebar tooltip. (elastic#103997) [Fleet + Integrations UI] Integrations UI Cleanup (elastic#104641) [Fleet] Link to download page of current stack version on Agent install instructions (elastic#104494) [Workplace Search] Fix Media Type field preview is unformatted bug (elastic#104684) [ML] add marker body (elastic#104672) ... # Conflicts: # x-pack/plugins/fleet/public/search_provider.test.ts
Summary
Closes #102491
Links the Go to download page button to the
past-releasesURL matching the current Kibana version.Also adds instructions on using the Linux installer over RPM/DEB, as these aren't present on the past release page:
Checklist