-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FieldFormats] Break from data
plugin
#107173
Conversation
# Conflicts: # src/plugins/data/common/search/aggs/utils/get_aggs_formats.ts # src/plugins/data/public/plugin.ts # src/plugins/data/public/public.api.md # src/plugins/field_formats/common/field_formats_registry.ts # src/plugins/field_formats/common/types.ts # src/plugins/field_formats/public/lib/field_formats_registry.stub.ts # src/plugins/field_formats/public/lib/field_formats_service.ts
⏳ Build in-progress, with failures
Failed CI StepsTo update your PR or re-run it, just comment with: |
# Conflicts: # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.castestokbnfieldtypename.md # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.getkbntypenames.md # docs/development/plugins/data/server/kibana-plugin-plugins-data-server.castestokbnfieldtypename.md # packages/kbn-field-types/BUILD.bazel # packages/kbn-field-types/package.json # packages/kbn-field-types/tsconfig.json # src/plugins/data/common/kbn_field_types/index.ts # src/plugins/data/common/kbn_field_types/types.ts # src/plugins/data/public/public.api.md # src/plugins/data/server/server.api.md # src/plugins/field_formats/common/converters/source.tsx # src/plugins/field_formats/common/converters/string.ts # src/plugins/field_formats/common/field_formats_registry.ts
# Conflicts: # src/plugins/index_pattern_management/public/components/field_editor/field_editor.tsx
# Conflicts: # packages/kbn-optimizer/limits.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test locally. Refactor to Watcher dependencies LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor items - I'll let you decide how you want to respond otherwise its good to go!
src/plugins/data/common/index_patterns/index_patterns/index_patterns.ts
Outdated
Show resolved
Hide resolved
src/plugins/data/public/actions/filters/create_filters_from_range_select.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SCSS import changes look fine to me.
# Conflicts: # src/plugins/data/public/public.api.md # src/plugins/data/server/server.api.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kibana App code changes LGTM, I also did a smoke test just to ensure that everything works fine!
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uptime changes LGTM
@elasticmachine merge upstream |
# Conflicts: # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.castestokbnfieldtypename.md # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.getkbntypenames.md # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.md # docs/development/plugins/data/server/kibana-plugin-plugins-data-server.castestokbnfieldtypename.md # src/plugins/data/public/public.api.md
* [FieldFormats] Break from `data` plugin (#107173) # Conflicts: # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.castestokbnfieldtypename.md # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.getkbntypenames.md # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.md # docs/development/plugins/data/server/kibana-plugin-plugins-data-server.castestokbnfieldtypename.md # src/plugins/data/public/public.api.md * update limits
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard_mode/dashboard_view_mode·js.dashboard mode Dashboard View Mode Dashboard viewer "before all" hook: Create dashboard only mode user for "shows only the dashboard app link"Standard Out
Stack Trace
Kibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/security/users·js.security app users should show the default rolesStandard Out
Stack Trace
Kibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/security/users·js.security app users should show the default rolesStandard Out
Stack Trace
Metrics [docs]Module Count
Public APIs missing comments
Any counts in public APIs
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
Summary
Close #106966
Breaking field formats from data plugin into a separate plugin.
For now, the data plugin re-exports field formats service on its setup/start contracts. This re-export is marked as deprecated.
In all other places where field formats code was imported statically, I changed it to import from field formats plugin directly.
Review
Apps review should be pretty straightforward, mostly change the path of static imports. But if those parts don't have sufficient test coverage, then worth smoke check for sanity.
Risk Matrix
fieldFormats
pluginPlugin API changes
fieldFormats
were extracted fromdata
plugin into a separate plugin. Checkexamples/field_formats_example
on how to use them.