Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [FieldFormats] Break from data plugin (#107173) #107761

Merged
merged 2 commits into from
Aug 5, 2021
Merged

[7.x] [FieldFormats] Break from data plugin (#107173) #107761

merged 2 commits into from
Aug 5, 2021

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Aug 5, 2021

Backports the following commits to 7.x:

@Dosant
[FieldFormats] Break from data plugin (elastic#107173)
4aa6a98 
# Conflicts:
#	docs/development/plugins/data/public/kibana-plugin-plugins-data-public.castestokbnfieldtypename.md
#	docs/development/plugins/data/public/kibana-plugin-plugins-data-public.getkbntypenames.md
#	docs/development/plugins/data/public/kibana-plugin-plugins-data-public.md
#	docs/development/plugins/data/server/kibana-plugin-plugins-data-server.castestokbnfieldtypename.md
#	src/plugins/data/public/public.api.md
@Dosant Dosant added the backport label Aug 5, 2021
@Dosant Dosant enabled auto-merge (squash) August 5, 2021 14:51
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
data 597 554 -43
fieldFormats - 64 +64
lens 734 739 +5
total +26

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.6MB 1.6MB -7.0B
dataVisualizer 1.1MB 1.1MB +49.0B
discover 508.9KB 509.0KB +53.0B
indexPatternFieldEditor 169.6KB 169.6KB +6.0B
lens 1.6MB 1.6MB +8.2KB
ml 5.9MB 5.9MB +99.0B
visTypeTimeseries 1003.9KB 1003.9KB -20.0B
visTypeVislib 564.4KB 564.4KB +6.0B
watcher 831.4KB 831.5KB +32.0B
total +8.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 27.2KB 27.4KB +239.0B
data 873.1KB 808.7KB -64.4KB
dataVisualizer 15.9KB 16.1KB +239.0B
discover 93.5KB 93.7KB +239.0B
fieldFormats - 76.1KB +76.1KB
indexPatternFieldEditor 46.9KB 47.1KB +263.0B
lens 28.9KB 29.1KB +239.0B
ml 64.5KB 64.7KB +239.0B
visDefaultEditor 33.9KB 34.1KB +237.0B
visTypeTimeseries 24.5KB 24.8KB +239.0B
visTypeVislib 32.4KB 32.7KB +239.0B
watcher 22.7KB 22.9KB +239.0B
total +14.0KB
Unknown metric groups

API count

id before after diff
data 3999 3690 -309
fieldFormats - 265 +265
total -44

API count missing comments

id before after diff
data 3447 3173 -274
fieldFormats - 235 +235
total -39

API count with any type

id before after diff
data 99 73 -26
fieldFormats - 26 +26
total -0

Non-exported public API item count

id before after diff
data 63 52 -11
fieldFormats - 10 +10
total -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit cda9966 into elastic:7.x Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dosant @kibanamachine