Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] [Exploratory View] revert exploratory view multi-series #107647

Merged

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Aug 4, 2021

Resolves #109170

This PR reverts #103855.

Exploratory view is currently in flux. Our goal is to finalize design concerns before releasing this feature. For this reason, we'd like to pull it from the master branch.

@dominiqueclarke dominiqueclarke added reverted v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Aug 4, 2021
@dominiqueclarke dominiqueclarke requested review from a team as code owners August 4, 2021 14:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Aug 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes look good.

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and smoke tests looked good to me. Approved, as long as we can verify we're not injecting e2e flakiness for APM tests I'm fine with this getting merged.

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@dominiqueclarke
Copy link
Contributor Author

Code and smoke tests looked good to me. Approved, as long as we can verify we're not injecting e2e flakiness for APM tests I'm fine with this getting merged.

These APM tests are failing on multiple branches for the past two days. We can safely say it's unrelated to this PR.

@dominiqueclarke dominiqueclarke merged commit 1649661 into elastic:master Aug 10, 2021
@dominiqueclarke dominiqueclarke deleted the revert/uptime-exporatory-view branch August 10, 2021 15:53
dominiqueclarke added a commit to dominiqueclarke/kibana that referenced this pull request Aug 10, 2021
andrewvc pushed a commit that referenced this pull request Aug 10, 2021
…#108079)

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661.

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661.
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 18, 2021

💔 Build Failed

Failed CI Steps


Test Failures

Kibana Pipeline / jest / Jest Tests.packages/kbn-es-archiver/src/lib/docs.indexes documents using the bulk client helper

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 7 times on tracked branches: https://github.com/elastic/kibana/issues/108043


Stack Trace

Error: expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `indexes documents using the bulk client helper 3`

Snapshot: [MockFunction] {
  "calls": Array [
    Array [
      Object {
        "datasource": Array [
          Object {
            "hello": "world",
          },
        ],
        "onDocument": [Function],
        "onDrop": [Function],
        "retries": 5,
      },
      Object {
        "headers": Object {
          "x-elastic-product-origin": "kibana",
        },
      },
    ],
    Array [
      Object {
        "datasource": Array [
          Object {
            "hello": "world",
          },
          Object {
            "hello": "world",
          },
          Object {
            "hello": "world",
          },
        ],
        "onDocument": [Function],
        "onDrop": [Function],
        "retries": 5,
      },
      Object {
        "headers": Object {
          "x-elastic-product-origin": "kibana",
        },
      },
    ],
  ],
  "results": Array [
    Object {
      "type": "return",
      "value": Promise {},
    },
    Object {
      "type": "return",
      "value": Promise {},
    },
  ],
}
Received: [MockFunction] {
  "calls": Array [
    Array [
      Object {
        "datasource": Array [
          Object {
            "hello": "world",
          },
        ],
        "onDocument": [Function],
        "onDrop": [Function],
        "retries": 5,
      },
      Object {
        "headers": Object {
          "x-elastic-product-origin": "kibana",
        },
      },
    ],
    Array [
      Object {
        "datasource": Array [
          Object {
            "hello": "world",
          },
          Object {
            "hello": "world",
          },
          Object {
            "hello": "world",
          },
        ],
        "onDocument": [Function],
        "onDrop": [Function],
        "retries": 5,
      },
      Object {
        "headers": Object {
          "x-elastic-product-origin": "kibana",
        },
      },
    ],
  ],
  "results": Array [
    Object {
      "type": "return",
      "value": Promise {
        Symbol(async_id_symbol): 1107041,
        Symbol(trigger_async_id_symbol): 1107028,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
      },
    },
    Object {
      "type": "return",
      "value": Promise {
        Symbol(async_id_symbol): 1107051,
        Symbol(trigger_async_id_symbol): 1107043,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
        Symbol(kResourceStore): undefined,
      },
    },
  ],
}
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/packages/kbn-es-archiver/src/lib/docs/index_doc_records_stream.test.ts:141:31)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 262 242 -20

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB -327.0B
observability 511.7KB 481.8KB -29.9KB
uptime 954.5KB 953.4KB -1.1KB
total -31.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 44.7KB 44.6KB -136.0B
observability 59.6KB 58.4KB -1.2KB
total -1.4KB
Unknown metric groups

API count

id before after diff
observability 223 219 -4

API count missing comments

id before after diff
observability 223 219 -4

Non-exported public API item count

id before after diff
observability 10 9 -1

References to deprecated APIs

id before after diff
observability 42 41 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dominiqueclarke added a commit to dominiqueclarke/kibana that referenced this pull request Aug 26, 2021
dominiqueclarke added a commit to dominiqueclarke/kibana that referenced this pull request Aug 26, 2021
dominiqueclarke added a commit to dominiqueclarke/kibana that referenced this pull request Aug 26, 2021
…elastic#108079)

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (elastic#107647)"

This reverts commit 1649661.

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (elastic#107647)"

This reverts commit 1649661.
dominiqueclarke added a commit to dominiqueclarke/kibana that referenced this pull request Aug 31, 2021
dominiqueclarke added a commit that referenced this pull request Oct 4, 2021
…113464)

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661.

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661.

* [Observability] [Exploratory View] Create multi series feature branch (#108079)

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661.

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661.

* update types

* update tests

* [Observability] exploratory view design issues (#111028)

* remove custom y axis labels for better clarity

* move add series button to the bottom

* disable auto apply

* fix missing test

* When series count changes, collapse other series. (#110894)

Co-authored-by: Kibana Machine <[email protected]>

* Feature/observability exploratory view multi series panels (#111555)

Co-authored-by: Kibana Machine <[email protected]>

* [Exploratory View] Fix date range picker on secondary series (#111700)

Co-authored-by: Kibana Machine <[email protected]>

* [Exploratory View] Collapse series only on add, not delete (#111790)

* [Exploratory view] Remove preview panel (#111884)

* [Exploratory view] implement popovers for data type and metric type (#112370)

* implement popovers for data type and metric type

* adjust types

* add IncompleteBadge

* make report metric dismissable

* show date-picker even if metric is undefined

* adjust styles of expanded series row

* add truncation to series name

* move incomplete badge and add edit pencil

* add tooltip to data type badge

* adjust content

* lint

* delete extra file

* move filters row

* adjust name editing behavior

* adjust filter styles

Co-authored-by: Kibana Machine <[email protected]>

* move cases button to top

* fix types

* more types :(

Co-authored-by: Justin Kambic <[email protected]>
Co-authored-by: shahzad31 <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Shahzad <[email protected]>
dominiqueclarke added a commit to dominiqueclarke/kibana that referenced this pull request Oct 6, 2021
…lastic#113464)

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (elastic#107647)"

This reverts commit 1649661.

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (elastic#107647)"

This reverts commit 1649661.

* [Observability] [Exploratory View] Create multi series feature branch (elastic#108079)

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (elastic#107647)"

This reverts commit 1649661.

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (elastic#107647)"

This reverts commit 1649661.

* update types

* update tests

* [Observability] exploratory view design issues (elastic#111028)

* remove custom y axis labels for better clarity

* move add series button to the bottom

* disable auto apply

* fix missing test

* When series count changes, collapse other series. (elastic#110894)

Co-authored-by: Kibana Machine <[email protected]>

* Feature/observability exploratory view multi series panels (elastic#111555)

Co-authored-by: Kibana Machine <[email protected]>

* [Exploratory View] Fix date range picker on secondary series (elastic#111700)

Co-authored-by: Kibana Machine <[email protected]>

* [Exploratory View] Collapse series only on add, not delete (elastic#111790)

* [Exploratory view] Remove preview panel (elastic#111884)

* [Exploratory view] implement popovers for data type and metric type (elastic#112370)

* implement popovers for data type and metric type

* adjust types

* add IncompleteBadge

* make report metric dismissable

* show date-picker even if metric is undefined

* adjust styles of expanded series row

* add truncation to series name

* move incomplete badge and add edit pencil

* add tooltip to data type badge

* adjust content

* lint

* delete extra file

* move filters row

* adjust name editing behavior

* adjust filter styles

Co-authored-by: Kibana Machine <[email protected]>

* move cases button to top

* fix types

* more types :(

Co-authored-by: Justin Kambic <[email protected]>
Co-authored-by: shahzad31 <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Shahzad <[email protected]>
# Conflicts:
#	test/functional/page_objects/common_page.ts
dominiqueclarke added a commit that referenced this pull request Oct 6, 2021
…113464) (#114120)

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661.

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661.

* [Observability] [Exploratory View] Create multi series feature branch (#108079)

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661.

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661.

* update types

* update tests

* [Observability] exploratory view design issues (#111028)

* remove custom y axis labels for better clarity

* move add series button to the bottom

* disable auto apply

* fix missing test

* When series count changes, collapse other series. (#110894)

Co-authored-by: Kibana Machine <[email protected]>

* Feature/observability exploratory view multi series panels (#111555)

Co-authored-by: Kibana Machine <[email protected]>

* [Exploratory View] Fix date range picker on secondary series (#111700)

Co-authored-by: Kibana Machine <[email protected]>

* [Exploratory View] Collapse series only on add, not delete (#111790)

* [Exploratory view] Remove preview panel (#111884)

* [Exploratory view] implement popovers for data type and metric type (#112370)

* implement popovers for data type and metric type

* adjust types

* add IncompleteBadge

* make report metric dismissable

* show date-picker even if metric is undefined

* adjust styles of expanded series row

* add truncation to series name

* move incomplete badge and add edit pencil

* add tooltip to data type badge

* adjust content

* lint

* delete extra file

* move filters row

* adjust name editing behavior

* adjust filter styles

Co-authored-by: Kibana Machine <[email protected]>

* move cases button to top

* fix types

* more types :(

Co-authored-by: Justin Kambic <[email protected]>
Co-authored-by: shahzad31 <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Shahzad <[email protected]>
# Conflicts:
#	test/functional/page_objects/common_page.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes reverted Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uptime] [Exploratory View] Revert multi series PR
6 participants