-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability] [Exploratory View] revert exploratory view multi-series #107647
[Observability] [Exploratory View] revert exploratory view multi-series #107647
Conversation
Pinging @elastic/uptime (Team:uptime) |
Pinging @elastic/apm-ui (Team:apm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APM changes look good.
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and smoke tests looked good to me. Approved, as long as we can verify we're not injecting e2e flakiness for APM tests I'm fine with this getting merged.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
These APM tests are failing on multiple branches for the past two days. We can safely say it's unrelated to this PR. |
…ti-series (elastic#107647)" This reverts commit 1649661.
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / jest / Jest Tests.packages/kbn-es-archiver/src/lib/docs.indexes documents using the bulk client helperStandard Out
Stack Trace
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsAPI count
API count missing comments
Non-exported public API item count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: |
…ti-series (elastic#107647)" This reverts commit 1649661.
…ti-series (elastic#107647)" This reverts commit 1649661.
…elastic#108079) * Revert "[Observability][Exploratory View] revert exploratory view multi-series (elastic#107647)" This reverts commit 1649661. * Revert "[Observability][Exploratory View] revert exploratory view multi-series (elastic#107647)" This reverts commit 1649661.
…ti-series (elastic#107647)" This reverts commit 1649661.
…113464) * Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)" This reverts commit 1649661. * Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)" This reverts commit 1649661. * [Observability] [Exploratory View] Create multi series feature branch (#108079) * Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)" This reverts commit 1649661. * Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)" This reverts commit 1649661. * update types * update tests * [Observability] exploratory view design issues (#111028) * remove custom y axis labels for better clarity * move add series button to the bottom * disable auto apply * fix missing test * When series count changes, collapse other series. (#110894) Co-authored-by: Kibana Machine <[email protected]> * Feature/observability exploratory view multi series panels (#111555) Co-authored-by: Kibana Machine <[email protected]> * [Exploratory View] Fix date range picker on secondary series (#111700) Co-authored-by: Kibana Machine <[email protected]> * [Exploratory View] Collapse series only on add, not delete (#111790) * [Exploratory view] Remove preview panel (#111884) * [Exploratory view] implement popovers for data type and metric type (#112370) * implement popovers for data type and metric type * adjust types * add IncompleteBadge * make report metric dismissable * show date-picker even if metric is undefined * adjust styles of expanded series row * add truncation to series name * move incomplete badge and add edit pencil * add tooltip to data type badge * adjust content * lint * delete extra file * move filters row * adjust name editing behavior * adjust filter styles Co-authored-by: Kibana Machine <[email protected]> * move cases button to top * fix types * more types :( Co-authored-by: Justin Kambic <[email protected]> Co-authored-by: shahzad31 <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Shahzad <[email protected]>
…lastic#113464) * Revert "[Observability][Exploratory View] revert exploratory view multi-series (elastic#107647)" This reverts commit 1649661. * Revert "[Observability][Exploratory View] revert exploratory view multi-series (elastic#107647)" This reverts commit 1649661. * [Observability] [Exploratory View] Create multi series feature branch (elastic#108079) * Revert "[Observability][Exploratory View] revert exploratory view multi-series (elastic#107647)" This reverts commit 1649661. * Revert "[Observability][Exploratory View] revert exploratory view multi-series (elastic#107647)" This reverts commit 1649661. * update types * update tests * [Observability] exploratory view design issues (elastic#111028) * remove custom y axis labels for better clarity * move add series button to the bottom * disable auto apply * fix missing test * When series count changes, collapse other series. (elastic#110894) Co-authored-by: Kibana Machine <[email protected]> * Feature/observability exploratory view multi series panels (elastic#111555) Co-authored-by: Kibana Machine <[email protected]> * [Exploratory View] Fix date range picker on secondary series (elastic#111700) Co-authored-by: Kibana Machine <[email protected]> * [Exploratory View] Collapse series only on add, not delete (elastic#111790) * [Exploratory view] Remove preview panel (elastic#111884) * [Exploratory view] implement popovers for data type and metric type (elastic#112370) * implement popovers for data type and metric type * adjust types * add IncompleteBadge * make report metric dismissable * show date-picker even if metric is undefined * adjust styles of expanded series row * add truncation to series name * move incomplete badge and add edit pencil * add tooltip to data type badge * adjust content * lint * delete extra file * move filters row * adjust name editing behavior * adjust filter styles Co-authored-by: Kibana Machine <[email protected]> * move cases button to top * fix types * more types :( Co-authored-by: Justin Kambic <[email protected]> Co-authored-by: shahzad31 <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Shahzad <[email protected]> # Conflicts: # test/functional/page_objects/common_page.ts
…113464) (#114120) * Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)" This reverts commit 1649661. * Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)" This reverts commit 1649661. * [Observability] [Exploratory View] Create multi series feature branch (#108079) * Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)" This reverts commit 1649661. * Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)" This reverts commit 1649661. * update types * update tests * [Observability] exploratory view design issues (#111028) * remove custom y axis labels for better clarity * move add series button to the bottom * disable auto apply * fix missing test * When series count changes, collapse other series. (#110894) Co-authored-by: Kibana Machine <[email protected]> * Feature/observability exploratory view multi series panels (#111555) Co-authored-by: Kibana Machine <[email protected]> * [Exploratory View] Fix date range picker on secondary series (#111700) Co-authored-by: Kibana Machine <[email protected]> * [Exploratory View] Collapse series only on add, not delete (#111790) * [Exploratory view] Remove preview panel (#111884) * [Exploratory view] implement popovers for data type and metric type (#112370) * implement popovers for data type and metric type * adjust types * add IncompleteBadge * make report metric dismissable * show date-picker even if metric is undefined * adjust styles of expanded series row * add truncation to series name * move incomplete badge and add edit pencil * add tooltip to data type badge * adjust content * lint * delete extra file * move filters row * adjust name editing behavior * adjust filter styles Co-authored-by: Kibana Machine <[email protected]> * move cases button to top * fix types * more types :( Co-authored-by: Justin Kambic <[email protected]> Co-authored-by: shahzad31 <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Shahzad <[email protected]> # Conflicts: # test/functional/page_objects/common_page.ts
Resolves #109170
This PR reverts #103855.
Exploratory view is currently in flux. Our goal is to finalize design concerns before releasing this feature. For this reason, we'd like to pull it from the master branch.