Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Exploratory View] Fix date range picker on secondary series #111700

Merged
merged 2 commits into from
Sep 10, 2021
Merged

[Exploratory View] Fix date range picker on secondary series #111700

merged 2 commits into from
Sep 10, 2021

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Sep 9, 2021 •
edited
Loading

Summary

Fixed a date range picker issue where it was using the start to populate both fields

Fix #111198

@shahzad31 shahzad31 marked this pull request as ready for review September 9, 2021 09:58
@shahzad31 shahzad31 requested a review from a team as a code owner September 9, 2021 09:58
@shahzad31 shahzad31 self-assigned this Sep 9, 2021
@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

justinkambic
justinkambic requested changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is fixed, but the selection of date values is not working. Whenever I change one value, the other is offset by 15 mins instead of the original selection.

Sep-09-2021 11-45-00

@dominiqueclarke
Copy link
Contributor

The issue is fixed, but the selection of date values is not working. Whenever I change one value, the other is offset by 15 mins instead of the original selection.

Sep-09-2021 11-45-00

Seeing the same

justinkambic
justinkambic approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, given that the date range picker is supposed to keep the same interval as the main series, LGTM.

@shahzad31 shahzad31 merged commit 08a640b into elastic:feature/observability-exploratory-view-multi-series Sep 10, 2021
@shahzad31 shahzad31 deleted the bug/fix-date-picker branch September 10, 2021 08:47
dominiqueclarke added a commit that referenced this pull request Oct 4, 2021
@dominiqueclarke @justinkambic
@shahzad31 @kibanamachine
[Observability] [Exploratory View] Add exploratory view multi series (#…
1ff02e1 
…113464)

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661.

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661.

* [Observability] [Exploratory View] Create multi series feature branch (#108079)

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661.

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661.

* update types

* update tests

* [Observability] exploratory view design issues (#111028)

* remove custom y axis labels for better clarity

* move add series button to the bottom

* disable auto apply

* fix missing test

* When series count changes, collapse other series. (#110894)

Co-authored-by: Kibana Machine <[email protected]>

* Feature/observability exploratory view multi series panels (#111555)

Co-authored-by: Kibana Machine <[email protected]>

* [Exploratory View] Fix date range picker on secondary series (#111700)

Co-authored-by: Kibana Machine <[email protected]>

* [Exploratory View] Collapse series only on add, not delete (#111790)

* [Exploratory view] Remove preview panel (#111884)

* [Exploratory view] implement popovers for data type and metric type (#112370)

* implement popovers for data type and metric type

* adjust types

* add IncompleteBadge

* make report metric dismissable

* show date-picker even if metric is undefined

* adjust styles of expanded series row

* add truncation to series name

* move incomplete badge and add edit pencil

* add tooltip to data type badge

* adjust content

* lint

* delete extra file

* move filters row

* adjust name editing behavior

* adjust filter styles

Co-authored-by: Kibana Machine <[email protected]>

* move cases button to top

* fix types

* more types :(

Co-authored-by: Justin Kambic <[email protected]>
Co-authored-by: shahzad31 <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Shahzad <[email protected]>
dominiqueclarke added a commit to dominiqueclarke/kibana that referenced this pull request Oct 6, 2021
@dominiqueclarke
[Observability] [Exploratory View] Add exploratory view multi series (e…
1c96a2a 
…lastic#113464)

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (elastic#107647)"

This reverts commit 1649661.

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (elastic#107647)"

This reverts commit 1649661.

* [Observability] [Exploratory View] Create multi series feature branch (elastic#108079)

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (elastic#107647)"

This reverts commit 1649661.

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (elastic#107647)"

This reverts commit 1649661.

* update types

* update tests

* [Observability] exploratory view design issues (elastic#111028)

* remove custom y axis labels for better clarity

* move add series button to the bottom

* disable auto apply

* fix missing test

* When series count changes, collapse other series. (elastic#110894)

Co-authored-by: Kibana Machine <[email protected]>

* Feature/observability exploratory view multi series panels (elastic#111555)

Co-authored-by: Kibana Machine <[email protected]>

* [Exploratory View] Fix date range picker on secondary series (elastic#111700)

Co-authored-by: Kibana Machine <[email protected]>

* [Exploratory View] Collapse series only on add, not delete (elastic#111790)

* [Exploratory view] Remove preview panel (elastic#111884)

* [Exploratory view] implement popovers for data type and metric type (elastic#112370)

* implement popovers for data type and metric type

* adjust types

* add IncompleteBadge

* make report metric dismissable

* show date-picker even if metric is undefined

* adjust styles of expanded series row

* add truncation to series name

* move incomplete badge and add edit pencil

* add tooltip to data type badge

* adjust content

* lint

* delete extra file

* move filters row

* adjust name editing behavior

* adjust filter styles

Co-authored-by: Kibana Machine <[email protected]>

* move cases button to top

* fix types

* more types :(

Co-authored-by: Justin Kambic <[email protected]>
Co-authored-by: shahzad31 <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Shahzad <[email protected]>
# Conflicts:
#	test/functional/page_objects/common_page.ts
dominiqueclarke added a commit that referenced this pull request Oct 6, 2021
@dominiqueclarke
[Observability] [Exploratory View] Add exploratory view multi series (#…
2832030 
…113464) (#114120)

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661.

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661.

* [Observability] [Exploratory View] Create multi series feature branch (#108079)

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661.

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661.

* update types

* update tests

* [Observability] exploratory view design issues (#111028)

* remove custom y axis labels for better clarity

* move add series button to the bottom

* disable auto apply

* fix missing test

* When series count changes, collapse other series. (#110894)

Co-authored-by: Kibana Machine <[email protected]>

* Feature/observability exploratory view multi series panels (#111555)

Co-authored-by: Kibana Machine <[email protected]>

* [Exploratory View] Fix date range picker on secondary series (#111700)

Co-authored-by: Kibana Machine <[email protected]>

* [Exploratory View] Collapse series only on add, not delete (#111790)

* [Exploratory view] Remove preview panel (#111884)

* [Exploratory view] implement popovers for data type and metric type (#112370)

* implement popovers for data type and metric type

* adjust types

* add IncompleteBadge

* make report metric dismissable

* show date-picker even if metric is undefined

* adjust styles of expanded series row

* add truncation to series name

* move incomplete badge and add edit pencil

* add tooltip to data type badge

* adjust content

* lint

* delete extra file

* move filters row

* adjust name editing behavior

* adjust filter styles

Co-authored-by: Kibana Machine <[email protected]>

* move cases button to top

* fix types

* more types :(

Co-authored-by: Justin Kambic <[email protected]>
Co-authored-by: shahzad31 <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Shahzad <[email protected]>
# Conflicts:
#	test/functional/page_objects/common_page.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

Assignees

@shahzad31 shahzad31

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahzad31 @kibanamachine @dominiqueclarke @justinkambic