-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new hello world plugin and adjust the welcome message. #107789
Add a new hello world plugin and adjust the welcome message. #107789
Conversation
b2fbb96
to
f9fbaf5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like the new menu structure
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/exception_operators_data_types/text·ts.detection engine api security and spaces enabled Detection exceptions data types and operators Rule exception operators for data type text "is not" operator will return 0 results if it cannot find what it is excludingStandard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
…#107789) * Add a new hello world plugin and adjust the welcome message. * update and move files * Update CODEOWNERS * add a tsconfig.json file * update tsconfig.json * fix type check * address code review comments # Conflicts: # .github/CODEOWNERS
…107789) (#108182) * Add a new hello world plugin and adjust the welcome message. (#107789) * Add a new hello world plugin and adjust the welcome message. * update and move files * Update CODEOWNERS * add a tsconfig.json file * update tsconfig.json * fix type check * address code review comments # Conflicts: # .github/CODEOWNERS * Update tsconfig.json Need to account for #108139 * Update tsconfig.json Needed to add references
I've gotten some feedback on the Developer Guide that the order of the documentation doesn't work well because it jumps into advanced concepts too quickly.
I decided to try to follow the React Docs which has a hello world plugin as one of the first things a user will read. I also created a
Contributing
section, as they have, and moved some of the Getting Started content into that.Before:

After:

I'm also considering renaming
tutorials
toAdvanced Guides
ala React as well.