[PieVis] PartitionVis integration to Lens.

[Kuznietsov]

Summary

Completes part of #121725 and #95902.

• Removed lens_pie expression and lens_pie_renderer.
• Removed styles, related to lens_pie_renderer.
• Replaced lens_pie with pieVis/mosaicVis/treemapVis/waffleVis expressions.
• Updated tests to reflect visualization changes.

[elasticmachine]

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

[flash1293]

This is mostly working fine, but I noticed a weird bug when changing the order of bucket dimensions:

Doesn't happen on main

[Kuznietsov]

@elasticmachine merge upstream

[flash1293]

Tested and didn't notice any problems except for the issue with changing/reordering dimensions.

@Kunzetsov I tested around a bit more and it's not only possible to run into this case on re-ordering the dimensions via drag and drop - it also happens e.g. on dragging in a new field.

I'm not feeling comfortable merging the PR this way even if we start working on a fix right away as it will break currently working behavior in subtle ways. For this PR, let's deploy a band-aid fix to be on the safe side:

In the pie expression building logic, use this piece of code to get the operations:

  const operations = datasource
    .getTableSpec()
    .map((col) => col.columnId)
    .filter((columnId) => layer.groups.includes(columnId))
    .map((columnId) => ({ columnId, operation: datasource.getOperationForColumnId(columnId) }))
    .filter((o): o is { columnId: string; operation: Operation } => !!o.operation);

It will ensure the order of the table is respected

[Kuznietsov]

Tested and didn't notice any problems except for the issue with changing/reordering dimensions.

@Kunzetsov I tested around a bit more and it's not only possible to run into this case on re-ordering the dimensions via drag and drop - it also happens e.g. on dragging in a new field.

I'm not feeling comfortable merging the PR this way even if we start working on a fix right away as it will break currently working behavior in subtle ways. For this PR, let's deploy a band-aid fix to be on the safe side:

In the pie expression building logic, use this piece of code to get the operations:

  const operations = datasource
    .getTableSpec()
    .map((col) => col.columnId)
    .filter((columnId) => layer.groups.includes(columnId))
    .map((columnId) => ({ columnId, operation: datasource.getOperationForColumnId(columnId) }))
    .filter((o): o is { columnId: string; operation: Operation } => !!o.operation);

It will ensure the order of the table is respected

As we've decided in the private conversation, I'll create the fix in a separate PR, merge it to the main, and only after that we'll come back to the current one.

[mbondyra]

EDIT: I read Joe's comment after testing, it's the same issue, sorry for the noise I started some initial testing and noticed a bug on Lens with reordering. When reordering two dimensions, they get duplicated (in the chart, not in the dimension panel)

[Kuznietsov]

EDIT: I started reading Joe's comment after testing, it's the same issue, sorry for the noise I started some initial testing and noticed a bug on Lens with reordering. When reordering two dimensions, they get duplicated (in the chart, not in the dimension panel)

@mbondyra, no problem)

[Kuznietsov]

@flash1293, @mbondyra, I'm close to finishing the fix of the current behavior at this PR: #125336

[mbondyra]

EmptyPlaceholder component takes icon, message and dataTestSubj parameters so I think you can replace this code with using it directly (you'd have to add iconType or something like this though). What do you think?

[Kuznietsov]

@mbondyra, updated the code, according to your proposition. Thanks for the suggestion)

[Kuznietsov]

@flash1293, tested on this branch. Working as expected.

Screen.Recording.2022-02-11.at.16.25.30.mov

[mbondyra]

Tested on Chrome and works as expected. I found some minor issues while testing with pie not related to this feature, but reproduced all on main branch so I'll just create new issues. Approved, code LGTM 👌🏼 Amazing job!

[Kuznietsov]

@elastic/security-asset-management @elastic/kibana-design, could you, please, review this PR. Thanks.

[Kuznietsov]

@elasticmachine merge upstream

[Kuznietsov]

@elasticmachine merge upstream

[Kuznietsov]

@elastic/security-asset-management, could you, please, review this PR?) Thanks)

[Kuznietsov]

@elasticmachine merge upstream

[Kuznietsov]

@elasticmachine merge upstream

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: e6fb686
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
expressionPartitionVis	49	56	+7
lens	744	734	-10
total			-3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
charts	286	288	+2
lens	316	343	+27
total			+29

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
expressionPartitionVis	42.5KB	47.0KB	+4.5KB
lens	1.0MB	1.0MB	-5.9KB
total			-1.4KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
lens	44	41	-3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
charts	58.3KB	58.4KB	+67.0B
expressionPartitionVis	20.1KB	20.1KB	+15.0B
lens	43.4KB	42.5KB	-901.0B
total			-819.0B

Unknown metric groups

API count

id	before	after	diff
charts	319	321	+2
lens	365	392	+27
total			+29

History

• 💔 Build #23808 failed f492215
• 💔 Build #23770 failed aa7db6a
• 💛 Build #23562 was flaky 0f144c4
• 💔 Build #23512 failed ed5fe34
• 💚 Build #23043 succeeded 877e39b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

[patrykkopycinski]

Asset management LGTM