-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PieVis] Adapt for Canvas and Lens. #121725
Comments
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
Pinging @elastic/kibana-presentation (Team:Presentation) |
The title and description in lens expression function is not needed anymore so I think we can remove them from the list :) |
Also the lens |
AFAIK Visualize pie doesn't support multiple metrics. While there's a use case for that, I think we shouldn't introduce it as part of this PR but split that out for later and stick with just a single metric dimension for now. The other settings look like they can be merged into a single renderer supporting everything pretty well. Please note that mosaic and waffle have additional limitations compared to pie/donut. Waffle only supports a single bucket/group dimension and Mosaic supports only up to two. |
@flash1293, added those details to the issue's text. |
Introduction
After moving out the
pieVis
expression fromvis_types
, it is required to decide what to add to the existent API ofpieVis
.Short investigation
Comparing
pieVis
fromvis_types
andlens_pie_renderer
, there are such differences in the API and in the functionality:Adaptation notes
Globally
data.fieldFormats
withfieldFormats
plugin.visdimension
at fields:metric
,bucket
,splitColumn
,splitRow
.palette
type fromstring
topalette
.Addressed at the PR: #121763
For Canvas
cc @crob611.
For Lens
mosaic
,treemap
andwaffle
charts.Source: #121725 (comment).
Addressed at the PR: #122420
@elastic/kibana-vis-editors, please, feel free to add some notes and plans to this issue.
cc @stratoula and @flash1293.
The text was updated successfully, but these errors were encountered: