Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] WaffleVis integration to Canvas. #124541

Closed
wants to merge 191 commits into from
Closed

[Canvas] WaffleVis integration to Canvas. #124541

wants to merge 191 commits into from

Conversation

Kuznietsov
Copy link
Contributor

Summary

Completes part of #121725 and #95902.

  • Added views/models/elements to Canvas for waffleVis.

Screenshot 2022-02-03 at 17 25 37

Kuznietsov and others added 30 commits December 17, 2021 18:11
@Kuznietsov
Moved pie_vis to the other.
d13df0b
@Kuznietsov
Added semicolon.
32a2a81
@Kuznietsov
Fixed check errors.
c5c41a6
@Kuznietsov
Removed not used types.
4c40252
@Kuznietsov
Changed docs.
6ef8429
@Kuznietsov
Fixed labels.
282c017
@Kuznietsov
Fixed more translation labels.
b01e118
@Kuznietsov
Merge branch 'main' into charts_expressions-pie
3231f72 
# Conflicts:
#	src/plugins/chart_expressions/expression_pie/common/expression_functions/pie_vis_function.test.ts
@Kuznietsov
Removed own types and replaced by expression_pie.
e54c816
@Kuznietsov
Changed types of buildExpressionFunction.
a363fb3
@Kuznietsov
Added limits and extraPublicDir.
7faa2b6
@Kuznietsov
Fixed i18n checks.
604f497
@Kuznietsov
Fixes.
1f9d54c
@Kuznietsov
More fixes.
90dd2ee
@Kuznietsov
Fixed translations checks.
c300657
@Kuznietsov
More translation fixes.
457e4f8
@Kuznietsov
Added displayName and help for renderer.
17d6c65
@Kuznietsov
Removed as statement.
679e11c
@kibanamachine
Merge branch 'main' into charts_expressions-pie
2160608
@Kuznietsov
Replaced data.fieldFormats with fieldFormats.
e83b93d
@Kuznietsov
Added support of visdimension.
37aacf8
@Kuznietsov
Fixed types of ExpressionValueVisDimension.
2e8cf1b
@kibanamachine
Merge branch 'main' into charts_expressions-pie-adaptation
de2a7a8
@Kuznietsov
Merge branch 'charts_expressions-pie' into charts_expressions-pie-ada…
5aacf11 
…ptation
@Kuznietsov
Fixed Arguments type of pie_labels.
4662d77
@Kuznietsov
Merge branch 'charts_expressions-pie' into charts_expressions-pie-ada…
6f4028e 
…ptation

# Conflicts:
#	src/plugins/chart_expressions/expression_pie/common/expression_functions/pie_labels_function.ts
@kibanamachine
Merge branch 'main' into charts_expressions-pie
25c9e6a
@Kuznietsov
Merge branch 'charts_expressions-pie' into charts_expressions-pie-ada…
ca687ef 
…ptation
@kibanamachine
Merge branch 'main' into charts_expressions-pie-adaptation
e2fa8fc
@Kuznietsov
Fixed wrong behavior of pie_vis without args.
ec12662
@Kuznietsov Kuznietsov added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. backport:skip This commit does not require backporting Feature:Canvas release_note:feature Makes this part of the condensed release notes v8.2.0 labels Feb 3, 2022
@Kuznietsov Kuznietsov self-assigned this Feb 3, 2022
@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

kibanamachine and others added 7 commits February 3, 2022 11:17
@kibanamachine
Merge branch 'main' into charts_expressions-waffle-canvas-integration
1d1da77
@kibanamachine
Merge branch 'main' into charts_expressions-pie-canvas-integration
7569ff1
@Kuznietsov
Merge branch 'main' into charts_expressions-pie-lens-adaptation
427a0a3
@Kuznietsov
Merge branch 'charts_expressions-pie-lens-adaptation' into charts_exp…
2e0fb6b 
…ressions-pie-lens-integration

# Conflicts:
#	x-pack/plugins/lens/public/pie_visualization/get_legend_action.test.tsx
@Kuznietsov
Merge branch 'charts_expressions-pie-lens-integration' into charts_ex…
da093a9 
…pressions-pie-canvas-integration
@Kuznietsov
Merge branch 'charts_expressions-pie-canvas-integration' into charts_…
752ea6e 
…expressions-treemap-canvas-integration
@Kuznietsov
Merge branch 'charts_expressions-treemap-canvas-integration' into cha…
3aca0eb 
…rts_expressions-waffle-canvas-integration
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1088 1098 +10
expressionPartitionVis - 49 +49
expressionPie 37 - -37
lens 736 726 -10
total +12

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
expressionPartitionVis - 70 +70
expressionPie 43 - -43
lens 259 286 +27
total +54

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.0MB 1.0MB +19.8KB
expressionPartitionVis - 42.4KB +42.4KB
expressionPie 39.5KB - -39.5KB
lens 1.0MB 1.0MB -5.2KB
visTypePie 8.4KB 8.7KB +264.0B
visTypeVislib 354.7KB 354.9KB +231.0B
total +18.0KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
expressionPartitionVis - 2 +2
expressionPie 2 - -2
lens 32 29 -3
total -3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionPartitionVis - 19.5KB +19.5KB
expressionPie 11.3KB - -11.3KB
lens 41.6KB 40.7KB -924.0B
visTypePie 7.9KB 8.1KB +153.0B
visTypeVislib 18.7KB 19.5KB +809.0B
total +8.2KB
Unknown metric groups

API count

id before after diff
expressionPartitionVis - 70 +70
expressionPie 43 - -43
lens 281 308 +27
total +54

async chunk count

id before after diff
expressionPartitionVis - 1 +1
expressionPie 1 - -1
total -0

ESLint disabled line counts

id before after diff
expressionPartitionVis - 3 +3
expressionPie 3 - -3
visualizations 16 17 +1
total +1

References to deprecated APIs

id before after diff
expressionPartitionVis - 6 +6
expressionPie 6 - -6
visTypePie 0 4 +4
total +4

Total ESLint disabled count

id before after diff
expressionPartitionVis - 3 +3
expressionPie 3 - -3
visualizations 18 19 +1
total +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

@Kuznietsov Kuznietsov closed this Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 Awaiting requested review from crob611

@alexwizp alexwizp Awaiting requested review from alexwizp

Assignees

@Kuznietsov Kuznietsov

Labels
backport:skip This commit does not require backporting Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:feature Makes this part of the condensed release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kuznietsov @kibana-ci @kibanamachine