Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Create index pattern" wizard. #12530

Closed
wants to merge 49 commits into from
Closed

"Create index pattern" wizard. #12530

wants to merge 49 commits into from

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Jun 28, 2017 •
edited
Loading

Addresses #10438, #5053, and #10440.

Changes to the UX

Loading indices

create_index_pattern_wizard_loading

Searching for matching indices

create_index_pattern_wizard_searching

Submitting the new index pattern

create_index_pattern_wizard_submit

Questions

  • @spalger I saw in the tests some assertions regarding cross-cluster search. However, when I tried to test the UI in master by creating an index pattern of log*:.kibana, I got a "no mappings found" error. Can you outline the expected UX here, or can we Zoom about it?
  • What does the Unable to fetch mapping. Do you have indices matching the pattern? error mean? Anybody know?
  • I can't make sense of the "expanded wildcard" explanation: With this option selected, searches against any time-based index pattern which contains a wildcard will automatically expand to query only the indices which contain data within the currently selected time range. We're "expanding a query" so that it "only" affects certain indices. This language seems contradictory. Can someone shed some light?
  • It seems like angular-translate isn't working as expected. According to the docs, translate-compile should allow you to embed tags into a translation string. However, it looks like the tags aren't compiling properly. I'd like to step through the translation process, but I had a hard time following the logic. @Bargs Could you walk me through this?

To-do in this PR

  • Fix bug: entering a partial match, then selecting all input, deleting it, and entering invalid input, doesn’t update the list with correct feedback.
  • Add unit tests for the UI.
  • Fix form validation when fields are untouched.
  • Implement polling for new data (and surface a spinner to show the UI is working for you).

Feedback

From @skearns64

  • The layout doesn't strongly connect the index pattern input and the search results
  • Where are we inside of the app? We need to underline the “Index Patterns” tab
  • We should hide the sidebar when creating a new index pattern
  • The sidebar warning is visually distracting. Let’s make it clearer in location, appearance, and language. (My note: this could be replaced with an improved onboarding message).
  • Let’s remove template index patterns for now and treat it as a later optimization.

This was referenced Jun 28, 2017
Closed
Closed
@cjcenizal cjcenizal force-pushed the 10438/index-pattern-creation-wizard branch 3 times, most recently from 942f55c to d968f84 Compare July 1, 2017 03:24
@alexfrancoeur
Copy link

I feel like we're missing some sort of graphic on the new index pattern flow. There's a lot of text that I'm worried people still skip over. What are your thoughts on providing some sort of graphic that explains an index pattern. It could be small even. ES is filled with documents, documents make up multiple indices, an index pattern is used to match against all those indices. It could almost look like a flow diagram. This might be unnecessary but I'd like to see how we can visually improve the page as well

@cjcenizal cjcenizal force-pushed the 10438/index-pattern-creation-wizard branch from c75a3f9 to 52eda5c Compare July 4, 2017 01:26
@cjcenizal cjcenizal mentioned this pull request Jul 4, 2017
Closed
@cjcenizal cjcenizal changed the title [WIP] Create index pattern creation wizard. Create index pattern creation wizard. Jul 4, 2017
@cjcenizal cjcenizal requested review from spalger and BigFunger July 4, 2017 20:15
@cjcenizal cjcenizal changed the title Create index pattern creation wizard. 'Create index pattern' wizard. Jul 4, 2017
@cjcenizal cjcenizal changed the title 'Create index pattern' wizard. "Create index pattern" wizard. Jul 4, 2017
@cjcenizal
Copy link
Contributor Author

jenkins, test this

@cjcenizal cjcenizal requested a review from snide July 5, 2017 16:24
cjcenizal added 10 commits July 5, 2017 11:43
@cjcenizal
Break index pattern creation form up into two sections.
850737e 
- Make button text static.
- Add link to help.
- Add matchingIndicesList directive.
@cjcenizal
Create Index Pattern Creation wizard.
c4e462e
@cjcenizal
Create a directive for each step in the wizard.
7ae46b1
@cjcenizal
Refine Wizard IA and improve translation key names.
7d8e724
@cjcenizal
Reorganize files into conventional folder structure.
dfbe7da
@cjcenizal
Rename files with more conventional and consistent naming patterns.
ee02e4a
@cjcenizal
Support user with feedback.
241e9c2 
- Display indices, partial matches, exact matches.
- Add loading, empty, and success states.
@cjcenizal
Make kbnInfo directive keyboard-accessible.
a72a361
@cjcenizal
Refine Step 2 UI.
b418549 
- Surface loading state when fetching time field options.
- Simplify time field logic.
- Remove unused translation keys.
@cjcenizal
Surface index pattern name form validation state in the UI.
8b18e5f
cjcenizal added 15 commits July 5, 2017 11:47
@cjcenizal
Fix bug which prevents advanced Time Filter field options from appear…
40bb1e6 
…ing.
@cjcenizal
Add kuiToggleButton disabled state.
ef507ff
@cjcenizal
Add isDisabled attribute to toggleButton and togglePanel directives.
7a42b94
@cjcenizal
Hide Expand Wildcard option beneath a toggle.
5e6a15c
@cjcenizal
Redesign toggleButton and togglePanel directive interfaces.
3e27f70
@cjcenizal
Update translations and internationalize new copy.
346581b
@cjcenizal
Add option to include system indices.
753db75
@cjcenizal
Remove all references to allTemplateIndexPatterns.
0790e45
@cjcenizal
Internationalize remaining copy.
9c66eed
@cjcenizal
Adjust rhythm of intro.
3f162d2
@cjcenizal
Fix functional tests.
c45bad3
@cjcenizal
Use info StatusText to present neutral indices search feedback.
44b89de
@cjcenizal
Remove createIndexPattern wizard unit tests.
25dcb4a
@cjcenizal
Untranslate strings which require interpolation.
d752fb7
@cjcenizal
Fix bug where entering invalid input didn't update the feedback message.
cf83d9f
@cjcenizal cjcenizal force-pushed the 10438/index-pattern-creation-wizard branch from b353c76 to cf83d9f Compare July 5, 2017 18:47
@snide
Copy link
Contributor

snide commented Jul 5, 2017

Don't think you want to show this control unless it's usable.

image

Move the include system indexes control in the list view, which is the content it effects. This also will keep it from appearing on step 2, where it's not needed.

image

image

@cjcenizal
Copy link
Contributor Author

@snide Good point about hiding the advanced options. I'll hide the checkbox in step 2. It needs to be available outside of step 1 because it's unchecked by default, so you'll get the "couldn't find data" prompt if you come here without any indices other than your system indices.

@cjcenizal cjcenizal mentioned this pull request Jul 6, 2017
Closed
5 tasks
@cjcenizal
Copy link
Contributor Author

Replacing this with #12689 (better commit history).

@cjcenizal cjcenizal closed this Jul 6, 2017
@cjcenizal cjcenizal deleted the 10438/index-pattern-creation-wizard branch July 6, 2017 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger Awaiting requested review from spalger

@BigFunger BigFunger Awaiting requested review from BigFunger

@snide snide Awaiting requested review from snide

Assignees
No one assigned
Labels
release_note:enhancement review v6.0.0-beta1 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjcenizal @alexfrancoeur @snide @epixa