Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Filebeat tutorials to instruct users to enable filesets #137803

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Aug 2, 2022

Summary

Adds a sentence to the Filebeat tutorials so users know that they must enable at least one fileset. Prior to 8.0.0, there were default filesets, so it was possible to enable the module and run it without modifying the yaml file.

Checklist

Related to elastic/observability-docs#1043

@dedemorton dedemorton requested a review from a team August 2, 2022 02:35
@dedemorton dedemorton self-assigned this Aug 2, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dedemorton

@dedemorton dedemorton added the release_note:skip Skip the PR/issue when compiling release notes label Aug 2, 2022
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text LGTM, with one comment. Is it clear to users what a "fileset" is?

@dedemorton
Copy link
Contributor Author

dedemorton commented Aug 2, 2022

@gchaps I think so. If not, the config files have links back to the documentation where we show all the filesets that are available and how to configure them. So if they're confused, there's a clear path to the docs that will help.

@dedemorton dedemorton added the backport:all-open Backport to all branches that could still receive a release label Aug 2, 2022
@dedemorton dedemorton merged commit 755fad1 into elastic:main Aug 2, 2022
@dedemorton dedemorton deleted the obs-issue#1043 branch August 2, 2022 23:00
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 2, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 2, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 2, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
7.17
8.3
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 3, 2022
kibanamachine added a commit that referenced this pull request Aug 3, 2022
kibanamachine added a commit that referenced this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.17.6 v8.3.4 v8.4.0 v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants