Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upgrade] Update when to run graph tests #137993

Merged
merged 2 commits into from
Aug 9, 2022
Merged

[Upgrade] Update when to run graph tests #137993

merged 2 commits into from
Aug 9, 2022

Conversation

liza-mae
Copy link
Contributor

@liza-mae liza-mae commented Aug 3, 2022

Fixes #130838

@liza-mae liza-mae added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.4.0 v7.17.6 v8.5.0 v8.3.4 labels Aug 3, 2022
@liza-mae liza-mae requested review from kertal and a team August 3, 2022 14:34
@liza-mae liza-mae self-assigned this Aug 3, 2022
@liza-mae
Copy link
Contributor Author

liza-mae commented Aug 8, 2022

@elasticmachine merge upstream

@liza-mae
Copy link
Contributor Author

liza-mae commented Aug 8, 2022

@kertal - can I get a review? Thanks.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @liza-mae

kertal
kertal approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did not nest manually, but it's an established pattern for skipping a test like this

@liza-mae liza-mae merged commit 2dfc992 into elastic:main Aug 9, 2022
@liza-mae liza-mae deleted the liza/fix-graph-test branch August 9, 2022 17:58
kibanamachine pushed a commit that referenced this pull request Aug 9, 2022
@liza-mae
Update when to run graph tests (#137993)
f7f04ea 
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 2dfc992)
@kibanamachine kibanamachine mentioned this pull request Aug 9, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Aug 9, 2022
@liza-mae
Update when to run graph tests (#137993)
3da38e9 
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 2dfc992)
@kibanamachine kibanamachine mentioned this pull request Aug 9, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Aug 9, 2022
@liza-mae
Update when to run graph tests (#137993)
3e38d3e 
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 2dfc992)
@kibanamachine kibanamachine mentioned this pull request Aug 9, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.4
✅ 7.17
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

cauemarcondes pushed a commit to cauemarcondes/kibana that referenced this pull request Aug 9, 2022
@kibanamachine @liza-mae
Update when to run graph tests (elastic#137993) (elastic#138440)
cacc3c3 
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 2dfc992)

Co-authored-by: liza-mae <[email protected]>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 10, 2022
@kibanamachine @liza-mae
Update when to run graph tests (elastic#137993) (elastic#138441)
d143c70 
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 2dfc992)

Co-authored-by: liza-mae <[email protected]>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 10, 2022
@kibanamachine @liza-mae
Update when to run graph tests (elastic#137993) (elastic#138442)
cfad70b 
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 2dfc992)

Co-authored-by: liza-mae <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

Assignees

@liza-mae liza-mae

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.17.6 v8.3.4 v8.4.0 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Upgrade] [Graph] Sample data is not available after upgrading, originating from 5.6 or 6.8
4 participants
@liza-mae @kibana-ci @kibanamachine @kertal