[Lens] Add control for global filters to the annotation layer menu

[dej611]

Summary

Closes #140204

This PR refactors the layer actions menu code and provide a way to each visualization to list custom actions when needed.
The first custom action to ship is the Ignore global filters in the annotation layer.

I've used the same visibility icon for the action, and modelled the UI as two distinct actions (Ignore vs Keep).

TSVB to Lens

The TSVB to Lens has been updated to create layers based on dataView used AND the ignoreGlobalFilters flag.

Bug fixes

A fix has been introduced for the scenario where the user didn't specify a dataView, as in TSVB this has a fallback to the default one. The fallback wasn't picked up by the conversion code originally, but now it is (added test for this).

Discussion points

• There's no actual way from the user perspective to know whether the filters are ignored or kept than open the action menu and check what's the current state/label in there. Is that ok? cc @ghudgins
• The icon user for the actual reflects the same icon(s) used to toggle the state of filters in Kibana. Is there anything better? cc @MichaelMarcialis
• The current feature state is modelled as two distinct actions. Is that ok?
  • A possible alternative would be to have a toggle switch on the same dropdown, keeping the same label. cc @MichaelMarcialis

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

[mbondyra]

😍👌🏼

[MichaelMarcialis]

• The icon user for the actual reflects the same icon(s) used to toggle the state of filters in Kibana. Is there anything better? cc @MichaelMarcialis

Yes! I'm planning to create a filter-specific ignore icon tomorrow and get it added to EUI (along with a handful of other Lens icons). Stay tuned. I'll CC you on the EUI PR.

• A possible alternative would be to have a toggle switch on the same dropdown, keeping the same label. cc @MichaelMarcialis

For now, my suggestion is that we keep it as you currently have it (with two distinct context menu actions) for the sake of aesthetics and simplicity, rather than using an EuiSwitch. I'm anticipating the number of layer-level actions growing quite quickly over the next few months; enough so that I imagine it will eventually outgrow a popover (and likely require a dedicated layer configuration flyout or modal). Until we hit that critical threshold though, I'd like to try to stick to a regular old context menu for as long as possible.

[dej611]

@MichaelMarcialis if that's ok for you I would like to merge this PR and then update the icon as follow up task when ready. would that be ok?

[mbondyra]

I checked it before and it works fine. However, I think the big problem is what you mentioned in the description (user not knowing if the annotation group keeps or ignores global filters). If we decide to solve it later, let me know.

Please solve the conflicts and I'll recheck and approve :)

Testing log:

• Lens to TSVB:
  • an annotation with ignoreGlobalFilters: true
  • an annotation with ignoreGlobalFilters: false
  • multi annotations with different settings that influence how the essags are grouped and ran:
    • indexPattern, timeField, ignoreGlobalFilters
• Lens annotations creation:
  • an annotation group with ignoreGlobalFilters: true
  • an annotation group with ignoreGlobalFilters: false
  • two annotations groups with the same dataView and same timeField but different ignoreGlobalFilters setting
  • moving an annotation from the group with ignoreGlobalFilters: true to ignoreGlobalFilters: false


[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 9f0dd9d

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
lens	917	918	+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
lens	565	567	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
lens	1.3MB	1.3MB	+1.3KB
visTypeTimeseries	493.2KB	493.5KB	+312.0B
total			+1.6KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
lens	43	45	+2

Unknown metric groups

API count

id	before	after	diff
lens	654	658	+4

History

• 💚 Build #76747 succeeded 6b82066
• 💔 Build #76511 failed 5030879
• 💛 Build #76390 was flaky 9e3997f
• 💚 Build #75353 succeeded c5647bd
• 💔 Build #75246 failed 2546b16
• 💔 Build #75240 failed f60d21e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[MichaelMarcialis]

@MichaelMarcialis if that's ok for you I would like to merge this PR and then update the icon as follow up task when ready. would that be ok?

Sounds good. I'll CC you when the icon is ready.