[Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled #157011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennypavlova
added
Team:Infra Monitoring UI - DEPRECATED
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
|
@jennypavlova can you add a storybook story about this new flag? Thanx |
…search-bar-with-auto-refresh-enabled
|
@stratoula Storybook added (also removed a duplicate one):
|
|
@elasticmachine merge upstream |
…search-bar-with-auto-refresh-enabled
stratoula
reviewed
May 12, 2023
| @@ -218,7 +221,7 @@ export function createSearchBar({ | |||
| filters={filters} | |||
| query={query} | |||
| onFiltersUpdated={defaultFiltersUpdated(data.query, props.onFiltersUpdated)} | |||
| onRefreshChange={defaultOnRefreshChange(data.query)} | |||
| onRefreshChange={defaultOnRefreshChange(data.query, props.isAutoRefreshDisabled)} | |||
There was a problem hiding this comment.
I think that there is no need to pass it to the function, just dont run the function if this prop is set to true
There was a problem hiding this comment.
I changed it to set undefined there if we have isAutoRefreshDisabled set to true otherwise it will use the function.
There was a problem hiding this comment.
I was thinking something like onRefreshChange={!props.isAutoRefreshDisabled ? defaultOnRefreshChange(data.query) : undefined}
There was a problem hiding this comment.
Oh I see, this is what you need. This is a nit but can you add the undefined as the else clause? As I have it on my comment?
There was a problem hiding this comment.
Sure, thanks for checking that! 🙂 I changed the condition to return the function if we don't have isAutoRefreshDisabled and otherwise to be undefined. Is that what you mean?
…search-bar-with-auto-refresh-enabled
…search-bar-with-auto-refresh-enabled
stratoula
approved these changes
Jun 13, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
@jennypavlova is it necessary to backport to the prev minor? |
@stratoula I added it because there we saw the issue with the hosts view data picker there and the backport will fix it |
jennypavlova
deleted the
156690-infrastructure-ui-hosts-view-unified-search-bar-with-auto-refresh-enabled
branch
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 13, 2023
…enabled (elastic#157011) Closes elastic#156690 ## Summary This PR adds a flag (`isAutoRefreshDisabled`) to disable the default auto-refresh option in the unified search. ## Background The auto refresh is added by default when using a unified search bar in [defaultOnRefreshChange](https://github.com/elastic/kibana/blob/main/src/plugins/unified_search/public/search_bar/create_search_bar.tsx/#L59) and it appeared on the host view page when currently the auto-refresh option is not supported. | with `isAutoRefreshDisabled` (true) | without `isAutoRefreshDisabled` (false/undefined) | | ------------------------------------ | -------------------------------------------------- | | <img width="200" alt="image" src="https://user-images.githubusercontent.com/14139027/236862888-63efdb13-6b07-41c2-abe8-88247c9c96e1.png"> | <img width="200" alt="image" src="https://user-images.githubusercontent.com/14139027/236862409-4f36ec6a-f274-4dae-960b-407ea30f330b.png"> | --------- Co-authored-by: Stratoula Kalafateli <[email protected]> (cherry picked from commit 77d864e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 13, 2023
…fresh enabled (#157011) (#159543) # Backport This will backport the following commits from `main` to `8.8`: - [[Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled (#157011)](#157011) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-13T08:07:58Z","message":"[Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled (#157011)\n\nCloses #156690 \r\n\r\n## Summary\r\n\r\nThis PR adds a flag (`isAutoRefreshDisabled`) to disable the default\r\nauto-refresh option in the unified search.\r\n\r\n## Background\r\n\r\nThe auto refresh is added by default when using a unified search bar in\r\n[defaultOnRefreshChange](https://github.com/elastic/kibana/blob/main/src/plugins/unified_search/public/search_bar/create_search_bar.tsx/#L59)\r\nand it appeared on the host view page when currently the auto-refresh\r\noption is not supported.\r\n\r\n\r\n| with `isAutoRefreshDisabled` (true) | without `isAutoRefreshDisabled`\r\n(false/undefined) |\r\n| ------------------------------------ |\r\n-------------------------------------------------- |\r\n| <img width=\"200\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/14139027/236862888-63efdb13-6b07-41c2-abe8-88247c9c96e1.png\">\r\n| <img width=\"200\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/14139027/236862409-4f36ec6a-f274-4dae-960b-407ea30f330b.png\">\r\n|\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli <[email protected]>","sha":"77d864e4ff04027f800789259fd6c6194b51c59a","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra Monitoring UI","release_note:skip","backport:prev-minor","v8.9.0"],"number":157011,"url":"https://github.com/elastic/kibana/pull/157011","mergeCommit":{"message":"[Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled (#157011)\n\nCloses #156690 \r\n\r\n## Summary\r\n\r\nThis PR adds a flag (`isAutoRefreshDisabled`) to disable the default\r\nauto-refresh option in the unified search.\r\n\r\n## Background\r\n\r\nThe auto refresh is added by default when using a unified search bar in\r\n[defaultOnRefreshChange](https://github.com/elastic/kibana/blob/main/src/plugins/unified_search/public/search_bar/create_search_bar.tsx/#L59)\r\nand it appeared on the host view page when currently the auto-refresh\r\noption is not supported.\r\n\r\n\r\n| with `isAutoRefreshDisabled` (true) | without `isAutoRefreshDisabled`\r\n(false/undefined) |\r\n| ------------------------------------ |\r\n-------------------------------------------------- |\r\n| <img width=\"200\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/14139027/236862888-63efdb13-6b07-41c2-abe8-88247c9c96e1.png\">\r\n| <img width=\"200\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/14139027/236862409-4f36ec6a-f274-4dae-960b-407ea30f330b.png\">\r\n|\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli <[email protected]>","sha":"77d864e4ff04027f800789259fd6c6194b51c59a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157011","number":157011,"mergeCommit":{"message":"[Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled (#157011)\n\nCloses #156690 \r\n\r\n## Summary\r\n\r\nThis PR adds a flag (`isAutoRefreshDisabled`) to disable the default\r\nauto-refresh option in the unified search.\r\n\r\n## Background\r\n\r\nThe auto refresh is added by default when using a unified search bar in\r\n[defaultOnRefreshChange](https://github.com/elastic/kibana/blob/main/src/plugins/unified_search/public/search_bar/create_search_bar.tsx/#L59)\r\nand it appeared on the host view page when currently the auto-refresh\r\noption is not supported.\r\n\r\n\r\n| with `isAutoRefreshDisabled` (true) | without `isAutoRefreshDisabled`\r\n(false/undefined) |\r\n| ------------------------------------ |\r\n-------------------------------------------------- |\r\n| <img width=\"200\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/14139027/236862888-63efdb13-6b07-41c2-abe8-88247c9c96e1.png\">\r\n| <img width=\"200\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/14139027/236862409-4f36ec6a-f274-4dae-960b-407ea30f330b.png\">\r\n|\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli <[email protected]>","sha":"77d864e4ff04027f800789259fd6c6194b51c59a"}}]}] BACKPORT--> Co-authored-by: jennypavlova <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 13, 2023
![https://user-images.githubusercontent.com/14139027/236862888-63efdb13-6b07-41c2-abe8-88247c9c96e1.png\">\r\n|](https://user-images.githubusercontent.com/14139027/236862888-63efdb13-6b07-41c2-abe8-88247c9c96e1.png\">\r\n|){kind=link}
![https://user-images.githubusercontent.com/14139027/236862409-4f36ec6a-f274-4dae-960b-407ea30f330b.png\">\r\n|\r\n\r\n---------\r\n\r\nCo-authored-by](https://user-images.githubusercontent.com/14139027/236862409-4f36ec6a-f274-4dae-960b-407ea30f330b.png\">\r\n|\r\n\r\n---------\r\n\r\nCo-authored-by){kind=link}
* main: (199 commits) [Lens] Add custom formatter within the Lens editor (elastic#158468) [Uptime] Hide app if no data is available (elastic#159118) [CodeEditor] Add grok highlighting (elastic#159334) Expose decoded cloudId components from the cloud plugin's contract (elastic#159442) [Profiling] Use collector and symbolizer integrations in the add data page (elastic#159481) [Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled (elastic#157011) [APM] Add feature flag for not available apm schema (elastic#158911) [Lens] Remove deprecated componentWillReceiveProps usage (elastic#159502) [api-docs] 2023-06-13 Daily api_docs build (elastic#159536) [data views] Use versioned router for REST routes (elastic#158608) [maps] fix geo line source not loaded unless maps application is opened (elastic#159432) [Enterprise Search][Search application]Fix Create Api key url (elastic#159519) [Security Solution] Increase timeout for indexing hosts (elastic#159518) dashboard Reset button disable (elastic#159430) [Security Solution] Unskip Endpoint API tests after package fix (elastic#159484) [Synthetics] adjust alert timing (elastic#159511) [ResponseOps][rule registry] Remove usages of `refresh: true` (elastic#159252) Revert "Remove unused package (elastic#158597)" [Serverless] Adding config to disable authentication on task manager background worker utilization API (elastic#159505) Remove unused package (elastic#158597) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #156690
Summary
This PR adds a flag (
isAutoRefreshDisabled) to disable the default auto-refresh option in the unified search.Background
The auto refresh is added by default when using a unified search bar in defaultOnRefreshChange and it appeared on the host view page when currently the auto-refresh option is not supported.
isAutoRefreshDisabled(true)isAutoRefreshDisabled(false/undefined)